Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[또링] 1단계 - 점진적인 리팩또링 미션 제출합니다. #86

Merged
merged 22 commits into from
Nov 27, 2020

Conversation

jnsorn
Copy link

@jnsorn jnsorn commented Nov 24, 2020

안녕하세요 화투님! 많이 늦어서 죄송합니다. 😭

이번 PR에서 구현한 내용

  • 키친포스의 요구사항 작성
  • Business Object에 대한 통합 테스트 작성

리뷰해주시면 열심히 고민해서 반영해보도록 하겠습니다! 🙏🏻

@jnsorn jnsorn changed the title [또링] 1단계 - 점진적인 리팩토링 미션 제출합니다. [또링] 1단계 - 점진적인 리팩또링 미션 제출합니다. Nov 25, 2020
Copy link

@phs1116 phs1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요, 또링!
테스트 하나하나 정말 꼼꼼하게 잘 작성해주셨네요! 👍
특별히 코멘트 드릴게 없어서 머지할게요. :)

@phs1116 phs1116 merged commit bbe7cb4 into woowacourse:jnsorn Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants