Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Malware-scan is not displaying verbose output on Mac environment #161

Closed
ewodrich opened this issue Nov 28, 2023 · 2 comments · Fixed by #165, #170, #176, #178 or #150
Closed

Malware-scan is not displaying verbose output on Mac environment #161

ewodrich opened this issue Nov 28, 2023 · 2 comments · Fixed by #165, #170, #176, #178 or #150
Assignees
@akenion @ewodrich
Labels
bug Something isn't working dev-complete Development work to resolve this issue is complete platform-specific A platform-specific issue or an inquiry about platform support qa-passed QA has tested and confirmed the fix for this issue
Milestone
v2.1.0

Comments

@ewodrich
Copy link

Running malware-scan on the latest rc2 on a Mac Ventura is not displaying verbose output either as default behavior or with specifying -v / --verbose. Also not displaying with the --debug option. This was also confirmed not displaying in --progress mode.

Found while testing case #132.
@ewodrich ewodrich added the bug Something isn't working label Nov 28, 2023
@ewodrich ewodrich added this to the v2.1.0 milestone Nov 28, 2023
@akenion akenion mentioned this issue Nov 29, 2023
Merged
@akenion akenion linked a pull request Nov 29, 2023 that will close this issue
Ensured logging is properly initialized in child processes #165
Merged
@akenion akenion self-assigned this Nov 29, 2023
@akenion akenion added platform-specific A platform-specific issue or an inquiry about platform support dev-complete Development work to resolve this issue is complete and removed dev-complete Development work to resolve this issue is complete labels Nov 29, 2023
@akenion akenion mentioned this issue Nov 29, 2023
Merged
@akenion akenion linked a pull request Nov 29, 2023 that will close this issue
Moved log settings to separate class to avoid serializing entire CliContext #170
Merged
akenion added a commit that referenced this issue Nov 29, 2023
@akenion
Merge branch 'gh-161' into milestone/2.1.0
4207c65
@akenion akenion added dev-complete Development work to resolve this issue is complete qa-ready Issue is ready for QA and included in the most recent release candidate labels Nov 29, 2023
@davidnuzik davidnuzik removed the dev-complete Development work to resolve this issue is complete label Nov 30, 2023
@akenion akenion removed the qa-ready Issue is ready for QA and included in the most recent release candidate label Nov 30, 2023
@akenion akenion mentioned this issue Nov 30, 2023
Merged
@akenion akenion linked a pull request Nov 30, 2023 that will close this issue
Disabled logging initializer when progress output is enabled #176
Merged
@akenion akenion added dev-complete Development work to resolve this issue is complete qa-ready Issue is ready for QA and included in the most recent release candidate and removed dev-complete Development work to resolve this issue is complete qa-ready Issue is ready for QA and included in the most recent release candidate labels Nov 30, 2023
@akenion
Copy link
Contributor

akenion commented Dec 1, 2023

The last fix prevented verbose output from being shown in the progress output on Mac.

@akenion akenion mentioned this issue Dec 1, 2023
Merged
@akenion akenion linked a pull request Dec 1, 2023 that will close this issue
Prevented set_log_format from causing errors when no handlers are present #178
Merged
akenion added a commit that referenced this issue Dec 1, 2023
@akenion
Merge branch 'gh-161' into milestone/2.1.0
8e34dd6
@akenion akenion added dev-complete Development work to resolve this issue is complete qa-ready Issue is ready for QA and included in the most recent release candidate labels Dec 1, 2023
@ewodrich
Copy link
Author

ewodrich commented Dec 5, 2023

Verified --verbose now displays as the default in both --progress mode and TTY. Also confirmed this is working on linux vm as well. This including verifying the following:

  • no-verbose
  • debug
  • no-debug
  • quiet
  • no-quiet
  • various -L log levels
  • prefix-log-levels

@ewodrich ewodrich removed the qa-ready Issue is ready for QA and included in the most recent release candidate label Dec 5, 2023
@ewodrich ewodrich added the qa-passed QA has tested and confirmed the fix for this issue label Dec 5, 2023
@akenion akenion mentioned this issue Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akenion akenion

@ewodrich ewodrich

Labels
bug Something isn't working dev-complete Development work to resolve this issue is complete platform-specific A platform-specific issue or an inquiry about platform support qa-passed QA has tested and confirmed the fix for this issue
Projects
None yet
Milestone
v2.1.0
3 participants
@akenion @davidnuzik @ewodrich