-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reader] Also add announcement card into the new Tags Feed #20877
[Reader] Also add announcement card into the new Tags Feed #20877
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/tags-ia #20877 +/- ##
===================================================
+ Coverage 41.01% 41.03% +0.01%
===================================================
Files 1509 1509
Lines 69289 69305 +16
Branches 11427 11429 +2
===================================================
+ Hits 28422 28437 +15
Misses 38291 38291
- Partials 2576 2577 +1 ☔ View full report in Codecov by Sentry. |
…ordpress-mobile/WordPress-Android into issue/20621-announcement-card-in-tags-feed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @thomashorta ! It's working as expected and code LGTM.
Quality Gate passedIssues Measures |
Part of #20621
shouldShow
from ReaderAnnouncementCard, since the visibility is managed by the Recycler Views and Lazy Columns.Warning
Should be merged after #20872
To Test:
This relies on a shared pref that is set when the card is dismissed, so to test multiple times you will need to clear app data (or if using an emulator push a shared pref file without the dismiss pref to override the app prefs file).
reader_announcement_card
feature config (in Debug settings)reader_announcement_card
feature config (in Debug settings)Your Tags
and except non-main feeds (e.g.: tag preview, blog preview, and filtered tags/blogs inYour Tags
andSubscriptions
)Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):