Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reader] Also add announcement card into the new Tags Feed #20877

Merged

Conversation

thomashorta
Copy link
Contributor

@thomashorta thomashorta commented May 24, 2024

Part of #20621

Warning

Should be merged after #20872


To Test:

This relies on a shared pref that is set when the card is dismissed, so to test multiple times you will need to clear app data (or if using an emulator push a shared pref file without the dismiss pref to override the app prefs file).

  1. Open Jetpack
  2. Turn off the reader_announcement_card feature config (in Debug settings)
  3. Restart the app
  4. Go to Reader
  5. Verify the announcement card does not show in any feeds
  6. Turn on the reader_announcement_card feature config (in Debug settings)
  7. Restart the app
  8. Go to Reader
  9. Verify the announcement card is shown in all feeds INCLUDING Your Tags and except non-main feeds (e.g.: tag preview, blog preview, and filtered tags/blogs in Your Tags and Subscriptions)

Regression Notes

  1. Potential unintended areas of impact

    • N/A
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • Updated existing tests
    • Added unit tests for new scenarios

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 24, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20877-a862f9b
Commita862f9b
Direct Downloadwordpress-prototype-build-pr20877-a862f9b.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 24, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20877-a862f9b
Commita862f9b
Direct Downloadjetpack-prototype-build-pr20877-a862f9b.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 41.03%. Comparing base (911be72) to head (a862f9b).
Report is 1 commits behind head on feature/tags-ia.

Files Patch % Lines
...der/viewmodels/tagsfeed/ReaderTagsFeedViewModel.kt 96.87% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           feature/tags-ia   #20877      +/-   ##
===================================================
+ Coverage            41.01%   41.03%   +0.01%     
===================================================
  Files                 1509     1509              
  Lines                69289    69305      +16     
  Branches             11427    11429       +2     
===================================================
+ Hits                 28422    28437      +15     
  Misses               38291    38291              
- Partials              2576     2577       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ordpress-mobile/WordPress-Android into issue/20621-announcement-card-in-tags-feed
Copy link
Contributor

@RenanLukas RenanLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @thomashorta ! It's working as expected and code LGTM.

Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Base automatically changed from issue/20621-announcement-card-in-feeds to feature/tags-ia May 24, 2024 19:53
@RenanLukas RenanLukas merged commit adf8393 into feature/tags-ia May 24, 2024
20 checks passed
@RenanLukas RenanLukas deleted the issue/20621-announcement-card-in-tags-feed branch May 24, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants