-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UL&S: VoiceOver support for site address flow #14588
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked as expected on iPhone X device with iOS 13.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While testing this I found what seems to be an issue when the user and password screen is shown (if VoiceOver is enabled when it comes up). The voice starts describing the title of this screen, and is interrupted when the focus is moved into the username field. I think we should either let it read the full screen description somehow, or prevent it from being read to begin with.
Here's a video showing the issue: https://cloudup.com/cw1-6dk7Pgd
Aside from the reported issue both tests run as described.
Darn. I thought I had fixed that issue. Thanks for testing, I'll look into a better solution. |
Moving to milestone 15.6 in case I can't fix the podspec errors in Auth by EOD. |
This PR will be merged only after 15.5 is cut. 🌻 |
...and UnifiedSignUpViewController
Ref. #14009
Ref. wordpress-mobile/WordPressAuthenticator-iOS#358
Auth PR: wordpress-mobile/WordPressAuthenticator-iOS#361
This PR updates three views to support VoiceOver:
And fixes bugs in the error handling that were only apparent after VoiceOver testing.
To test the Site Address flow
.unifiedSiteAddress
feature flagrake dependencies
Hey Siri turn on VoiceOver
hey siring turn off VoiceOver
so you can type in the address URL faster). Enter an invalid site, such as: fb.com (turn VoiceOver on again). Continue. Expected: the VoiceOver focus changes and reads the error message.To test the first Unified Sign Up screen
.unifiedSignup
feature flagPR submission checklist:
RELEASE-NOTES.txt
if necessary.