-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jetpack Focus] Add Jetpack banner to People view #19797
Conversation
Cross-referencing in case it's of any use: #19103 |
You can test the changes in Jetpack from this Pull Request by:
|
You can test the changes in WordPress from this Pull Request by:
|
a0af2cd
to
3fc46ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested all the listed scenarios and it works as expected 🚀
Regarding the two know issues you've mentioned, I was able to reproduce both. These look like low priority issues, but I was curios, do you think we should track them somewhere in case we have time to tackle them in the future?
Thanks @hassaanelgarem! I just found a minor issue that I'll tweak, the view's title is missing now that it's wrapped.
I think that's a good idea and will create issues for them. 👍 |
6be64cf
to
25e5cbe
Compare
@hassaanelgarem this should be resolved with 25e5cbe. I've also updated the screenshot in this PR to match. |
Part of #19448
Description
JetpackBrandingCoordinator.shouldShowBannerForJetpackDependentFeatures()
returnstrue
JetpackBrandingCoordinator.shouldShowBannerForJetpackDependentFeatures()
returnstrue
Known issues:
Testing
Banner and badge only appear during phases 2 and 3
Toggle the Jetpack Features Removal feature flags and confirm that:
Banner appears in the People view in WordPress
🔵 Tracked: jetpack_powered_banner_tapped <screen: people>
to be fired.Badge appears in the Person view in WordPress
🔵 Tracked: jetpack_powered_badge_tapped <screen: person>
to be fired.Banner and badge do not appear in Jetpack
Banner visibility behavior
Items to test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.