Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifications Refresh] Implement component for Comment Moderation and Likes header #23075

Conversation

salimbraksa
Copy link
Contributor

@salimbraksa salimbraksa commented Apr 24, 2024

Part of

  • 16-gh-Automattic/wordpress-mobile
  • 29-gh-Automattic/wordpress-mobile
 Light Dark
CleanShot 2024-04-24 at 11 50 16@2x CleanShot 2024-04-24 at 11 49 57@2x

Test Instructions

Verify the component matches the design

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@salimbraksa salimbraksa changed the base branch from trunk to feature/notifications_refresh_p2 April 24, 2024 11:06
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 24, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23075-efee7cd
Version24.7
Bundle IDorg.wordpress.alpha
Commitefee7cd
App Center BuildWPiOS - One-Offs #9643
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 24, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23075-efee7cd
Version24.7
Bundle IDcom.jetpack.alpha
Commitefee7cd
App Center Buildjetpack-installable-builds #8687
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@salimbraksa salimbraksa force-pushed the task/notifications-comment-moderation-header branch 2 times, most recently from 06dd4e7 to 0ce20f0 Compare April 24, 2024 11:28
@salimbraksa salimbraksa self-assigned this Apr 24, 2024
@salimbraksa salimbraksa added this to the Pending milestone Apr 24, 2024
@salimbraksa salimbraksa marked this pull request as ready for review April 24, 2024 11:29
// .padding()
// }
//}
//#endif
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, this code breaks the SwiftUI Previews even when the "Design System" target is selected.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean it breaks all the other previews too? I uncommented it, and this particular preview really doesn't work, but the ContentPreview works perfectly. 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my case I get this error when trying to preview the ContentPreview view:

CleanShot 2024-04-24 at 17 09 27@2x

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it's a local issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved the issue by deleting DynamicDashboardCard.swift file and adding it again 🤷‍♂️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Try to restart your computer"-like classic 😄

@salimbraksa salimbraksa force-pushed the task/notifications-comment-moderation-header branch from 0ce20f0 to c0a4a5d Compare April 24, 2024 12:28
Copy link
Contributor

@justtwago justtwago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you Salim! Love it how the rows are animated on clicks. 👏

@salimbraksa salimbraksa merged commit 3a5728d into feature/notifications_refresh_p2 Apr 24, 2024
3 of 18 checks passed
@salimbraksa salimbraksa deleted the task/notifications-comment-moderation-header branch April 24, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants