Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifications P1] Comment Moderation View #23127

Conversation

alpavanoglu
Copy link
Contributor

@alpavanoglu alpavanoglu commented Apr 30, 2024

Refs #https://github.com/Automattic/wordpress-mobile/issues/33

Description

This PR adds a customisable moderation view for all moderation states. This component will be used in the following Comment Moderation Tickets [#https://github.com/Automattic/wordpress-mobile/issues/33, #https://github.com/Automattic/wordpress-mobile/issues/34, #https://github.com/Automattic/wordpress-mobile/issues/35, #https://github.com/Automattic/wordpress-mobile/issues/36]

Testing Steps

Actions are not yet implemented other than causing the state & UI to change. ViewModel is in place to allow further implementation. UI is not attached to the flow so testing is possible via Previews.

Go to CommentModerationView.swift file and enable canvas (comment out didFinishLaunchingWithOptions and willFinishLaunchingWithOptions functions in WordPressAppDelegate and select WordPress as build target instead of Jetpack). Scrolling horizontally will reveal all possible states. Each one is interactive. Verify if the designs match to yWt5gg3nWORhu079Qfv3mS-fi-1118_2402 (the button colors are updated to sync with Design System Component).

Screenshot Reference

The tertiary button is blue instead of Jetpack green due to running WordPress build for Previews. The dyanmic Design System color is used.

Screen.Recording.2024-04-30.at.18.27.02.mov

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 30, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23127-dca0bf6
Version24.8
Bundle IDorg.wordpress.alpha
Commitdca0bf6
App Center BuildWPiOS - One-Offs #9854
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 30, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23127-dca0bf6
Version24.8
Bundle IDcom.jetpack.alpha
Commitdca0bf6
App Center Buildjetpack-installable-builds #8902
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@alpavanoglu alpavanoglu changed the title Feature/notifications p2 comment moderation view [Notifications P1] Comment Moderation View May 1, 2024

private let animationDuration = 0.25

private let insertionAnimationDelay = 0.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alpavanoglu There was a small regression when I pushed this commit fc2c176

Suggested change
private let insertionAnimationDelay = 0.8
private var insertionAnimationDelay: TimeInterval {
return animationDuration * 0.8
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in: e1b1031

LMK if it is fine now. If so we can merge

Copy link
Contributor

@salimbraksa salimbraksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@alpavanoglu alpavanoglu merged commit b552e09 into feature/notifications_refresh_p2 May 9, 2024
24 checks passed
@alpavanoglu alpavanoglu deleted the feature/notifications-p2_comment_moderation_view branch May 9, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants