-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Notifications P1] Comment Moderation View #23127
[Notifications P1] Comment Moderation View #23127
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
|
||
private let animationDuration = 0.25 | ||
|
||
private let insertionAnimationDelay = 0.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @alpavanoglu There was a small regression when I pushed this commit fc2c176
private let insertionAnimationDelay = 0.8 | |
private var insertionAnimationDelay: TimeInterval { | |
return animationDuration * 0.8 | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in: e1b1031
LMK if it is fine now. If so we can merge
…tions-p2_comment_moderation_view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
b552e09
into
feature/notifications_refresh_p2
Refs #https://github.com/Automattic/wordpress-mobile/issues/33
Description
This PR adds a customisable moderation view for all moderation states. This component will be used in the following Comment Moderation Tickets [#https://github.com/Automattic/wordpress-mobile/issues/33, #https://github.com/Automattic/wordpress-mobile/issues/34, #https://github.com/Automattic/wordpress-mobile/issues/35, #https://github.com/Automattic/wordpress-mobile/issues/36]
Testing Steps
Actions are not yet implemented other than causing the state & UI to change. ViewModel is in place to allow further implementation. UI is not attached to the flow so testing is possible via Previews.
Go to
CommentModerationView.swift
file and enable canvas (comment outdidFinishLaunchingWithOptions
andwillFinishLaunchingWithOptions
functions inWordPressAppDelegate
and selectWordPress
as build target instead ofJetpack
). Scrolling horizontally will reveal all possible states. Each one is interactive. Verify if the designs match to yWt5gg3nWORhu079Qfv3mS-fi-1118_2402 (the button colors are updated to sync with Design System Component).Screenshot Reference
The tertiary button is blue instead of Jetpack green due to running
WordPress
build for Previews. The dyanmic Design System color is used.Screen.Recording.2024-04-30.at.18.27.02.mov
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: