Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue with post excerpt not reloading in the list #23232

Merged
merged 2 commits into from
May 20, 2024
Merged

Fix an issue with post excerpt not reloading in the list #23232

merged 2 commits into from
May 20, 2024

Conversation

kean
Copy link
Contributor

@kean kean commented May 20, 2024

To test:

  • Open Post List in the app
  • (On the web or other client) modify the content of one of the posts
  • Return to the app
  • Pull-to-refresh
  • Verify that excerpt changed

Regression Notes

  1. Potential unintended areas of impact: Post List
  2. What I did to test those areas of impact (or what existing automated tests I relied on): n/a
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added this to the 24.9 ❄️ milestone May 20, 2024
@kean kean requested a review from momo-ozawa May 20, 2024 12:15
@kean kean changed the base branch from trunk to release/24.9 May 20, 2024 12:15
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 24.9 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

kean
kean commented May 20, 2024
View reviewed changes
WordPress/Classes/Services/PostHelper.m
post = [blog lookupPostWithForeignID:foreignID inContext:context];
} else {
post = [blog lookupPostWithID:remotePost.postID inContext:context];
AbstractPost *post = [blog lookupPostWithID:remotePost.postID inContext:context];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started testing by looking into this area. The first lookup that should happen is the postID lookup. The current version performs only a foreignID lookup. I can't come up with scenarios where this might be an issue, but it's better to keep the postID logic in place.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23232-002c6ab
Version24.9
Bundle IDcom.jetpack.alpha
Commit002c6ab
App Center Buildjetpack-installable-builds #8995
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23232-002c6ab
Version24.9
Bundle IDorg.wordpress.alpha
Commit002c6ab
App Center BuildWPiOS - One-Offs #9945
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

kean
kean commented May 20, 2024
View reviewed changes
WordPress/Classes/Models/Post.swift
override func didChangeValue(forKey key: String) {
super.didChangeValue(forKey: key)

if key == "mt_excerpt" || key == "content" {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turned out to be not enough. I decided to remove caching for now to be safe.

@kean kean merged commit 0fa82a2 into release/24.9 May 20, 2024
25 of 27 checks passed
@kean kean deleted the fix/foreign-id-lookup branch May 20, 2024 17:09
@kean kean mentioned this pull request May 24, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momo-ozawa momo-ozawa momo-ozawa approved these changes

Assignees
No one assigned
Labels
Posts + Pages [Type] Bug
Projects
None yet
Milestone
24.9
Development

Successfully merging this pull request may close these issues.
4 participants
@kean @dangermattic @wpmobilebot @momo-ozawa