UL&S: Remove .showSigninV2
#232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navigate programmatically
Also delete storyboard placeholder from SignupEmailVC
mindgraffiti
commented
Apr 6, 2020
| // LoginFacadeDelegate methods for Google Google Sign In | ||
| /// Make Google Sign In conform to the LoginFacade protocol. | ||
| /// The delegate calls these methods from LoginFacade.m. | ||
| /// |
There was a problem hiding this comment.
This is documentation I forgot to update for the previous segue removal, .show2fa
mindgraffiti
commented
Apr 6, 2020
| @@ -522,6 +532,9 @@ extension LoginEmailViewController { | |||
| googleExistingUserNeedsConnection(email) | |||
| } | |||
|
|
|||
| /// After a successful Google Sign In, this method gets called when the user | |||
| /// has enabled 2-factor authentication for their WordPress.com account. | |||
| /// | |||
There was a problem hiding this comment.
This is documentation I forgot to update for the previous segue removal, .show2fa
This prepare for segue is no longer used because login in by email and login by google are done using nav controllers rather than calling perform segue.
3 tasks
ScoutHarris
approved these changes
Apr 6, 2020
bjtitus
reviewed
Apr 7, 2020
There was a problem hiding this comment.
Tested with the work from wordpress-mobile/WordPress-iOS#13828 (review)
|
Thank you @ScoutHarris and @bjtitus ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #229
Ref. #182
This PR removes all references to the segue
.showSigninV2and programmatically navigates the user to theSignupEmailViewController. There is 1 area where the segue has been removed:To Test - WPiOS
rake dependenciesand ensure there are no errorsshowSigninV2WordPress-iOS#13828