UL&S: Site Address tableView and continue button #294
Conversation
| self.emailLoginInstructions = emailLoginInstructions | ||
| self.jetpackLoginInstructions = jetpackLoginInstructions | ||
| self.siteLoginInstructions = siteLoginInstructions | ||
| self.siteAddressPrimaryButton = siteAddressPrimaryButton |
There was a problem hiding this comment.
This seems to indicate we're going to have a string for every button on every view. That seems a bit excessive. Does the button text need to be customized? And to this level of granularity? It looks like host apps will typically use the same text for the same actions.
If we do need to customize the button text, I'm wondering if maybe we can have more generic strings, like continue, done, openMail , i.e. customize the text for the action instead of the view.
What do you think?
There was a problem hiding this comment.
I'm overthinking it. More generic names for strings sounds better to me!
|
@Gio2018 |
Ok then, I was missing something 🙂 |
There was a problem hiding this comment.
Other than one nitpick about the string comment, looks good! Tested with wordpress-mobile/WordPress-iOS#14230.
| siteLoginInstructions: NSLocalizedString("Enter the address of the WordPress site you'd like to connect.", | ||
| comment: "Instruction text on the login's site addresss screen."), | ||
| continueButtonTitle: NSLocalizedString("Continue", | ||
| comment: "The primary call-to-action button text on the unified site address screen.") |
There was a problem hiding this comment.
This comment should probably be generic.
|
Oh, I just noticed the podspec version wasn't update. Probably should be |
|
Thank you for the reviews @Gio2018 and @ScoutHarris! |
Ref. #283
Ref. wordpress-mobile/WordPress-iOS#14230
This PR removes the temporary label, adds the tableView, and adds the continue button. The
SiteAddressViewControllernow inherits from theLoginViewControllerso that it can pick up thesubmitButtonbehaviors found inNUXViewController.To test
bundle exec pod install