Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Metro sourceExts config #5684

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Update Metro sourceExts config #5684

merged 2 commits into from
Apr 19, 2023

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Apr 19, 2023 •
edited
Loading

Related PRs:

This PR brings changes from the referenced PR above and includes the same cjs addition to Metro's sourceExts config in Gutenberg Mobile.

To test CI checks should pass.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added the Tooling label Apr 19, 2023
@geriux geriux marked this pull request as ready for review April 19, 2023 13:06
dcalhoun
dcalhoun approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I verified npm run start:reset and npm run bundle succeeded.

@geriux geriux merged commit 7a7f64d into trunk Apr 19, 2023
@geriux geriux deleted the fix/missing-metro-config branch April 19, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees
No one assigned
Labels
Tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geriux @dcalhoun