Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable VideoPress block on iOS #5692

Merged
merged 9 commits into from
Apr 21, 2023
Merged

Enable VideoPress block on iOS #5692

merged 9 commits into from
Apr 21, 2023

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Apr 21, 2023

Related PRs:

This PR enables the VideoPress block on iOS as it will released first on that platform. In the next few days, we plan to ship the Android version.

NOTE: ⚠️ The VideoPress block only works on Simple WPCOM sites.

To test

iOS

  1. Open the app and connect it with the local Metro server.
  2. Open/create a post.
  3. Tap ➕ button to open the block inserter.
  4. Observe that the VideoPress block is displayed.
  5. Tap on the VideoPress block to add it.
  6. Add a video.
  7. Observe that the video is displayed and can be played.

Example:

Android

  1. Follow the steps from the iOS test case.
  2. Observe that the VideoPress block is displayed while in dev mode.
  3. Tap on the three dots button -> Debug Menu -> Settings.
  4. Disable JS Dev Mode.
  5. Reload the editor by tapping on the three dots button -> Reload.
  6. Observe that the VideoPress block is displayed as unsupported.
  7. Tap ➕ button to open the block inserter.
  8. Observe that the VideoPress block is NOT displayed.

NOTE: Repeat steps 3 and 4 (enable JS Dev Mode) to go back to dev mode.

Example:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added this to the 1.94.0 (22.3) milestone Apr 21, 2023
@fluiddot fluiddot self-assigned this Apr 21, 2023
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 21, 2023

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

jetpack Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bumped the Jetpack ref to incorporate the changes from Automattic/jetpack#30071. Note that it's not pointing to the latest commit from trunk.

@fluiddot fluiddot marked this pull request as ready for review April 21, 2023 10:27
@fluiddot fluiddot requested review from SiobhyB and jhnstn April 21, 2023 11:22
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left one small question/comment about the release notes, but nothing at all blocking, going ahead to approve :D 😎

RELEASE-NOTES.txt Outdated Show resolved Hide resolved
# Conflicts:
#	bundle/ios/App.js
#	bundle/ios/App.js.map
@fluiddot fluiddot merged commit df9654b into trunk Apr 21, 2023
@fluiddot fluiddot deleted the enable-videopress-block-ios branch April 21, 2023 17:30
@jhnstn jhnstn mentioned this pull request Apr 27, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants