-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update XCFramework setup to work with React Native 0.71.11 #5924
Update XCFramework setup to work with React Native 0.71.11 #5924
Commits on Jun 21, 2023
-
Siobhan committed
Jun 21, 2023 Configuration menu - View commit details
-
Copy full SHA for cfe592e - Browse repository at this point
Copy the full SHA cfe592eView commit details
Commits on Jun 22, 2023
-
Update script for generating React-Codegen
The method we used to generate React-Codegen (get_react_codegen_spec) was moved to a different file in newer versions of React Native. We need to update the script for generating it accordingly.
Siobhan committedJun 22, 2023 Configuration menu - View commit details
-
Copy full SHA for e7bf780 - Browse repository at this point
Copy the full SHA e7bf780View commit details -
Update third-party podspecs to target 0.71.11
Siobhan committedJun 22, 2023 Configuration menu - View commit details
-
Copy full SHA for 17e4705 - Browse repository at this point
Copy the full SHA 17e4705View commit details -
Update FBReactNativeSpec.podspec.json with hash
Siobhan committedJun 22, 2023 Configuration menu - View commit details
-
Copy full SHA for 2aca7ac - Browse repository at this point
Copy the full SHA 2aca7acView commit details -
Siobhan committed
Jun 22, 2023 Configuration menu - View commit details
-
Copy full SHA for 165d681 - Browse repository at this point
Copy the full SHA 165d681View commit details -
Manually add React-bridging.podspec.json
The file was automatically deleted via the generate-podspecs.sh script. It has been manually added as a temporary measure, to enable further testing.
Siobhan committedJun 22, 2023 Configuration menu - View commit details
-
Copy full SHA for 9707305 - Browse repository at this point
Copy the full SHA 9707305View commit details
Commits on Jun 23, 2023
-
Revert "Manually add React-bridging.podspec.json"
This reverts commit 9707305.
Siobhan committedJun 23, 2023 Configuration menu - View commit details
-
Copy full SHA for 30b052f - Browse repository at this point
Copy the full SHA 30b052fView commit details
Commits on Jun 25, 2023
-
Update list of dependencies in Podfile for iOS
Siobhan committedJun 25, 2023 Configuration menu - View commit details
-
Copy full SHA for c89ef2a - Browse repository at this point
Copy the full SHA c89ef2aView commit details -
Add tag to Hermes podspec to workaround error
This is intended as a temporary workaround, we should implement a more robust fix before merging.
Siobhan committedJun 25, 2023 Configuration menu - View commit details
-
Copy full SHA for 819d005 - Browse repository at this point
Copy the full SHA 819d005View commit details -
Update dependency versions in Podfile.lock
Siobhan committedJun 25, 2023 Configuration menu - View commit details
-
Copy full SHA for 64bf6d7 - Browse repository at this point
Copy the full SHA 64bf6d7View commit details
Commits on Jun 26, 2023
-
[Temporary] Add React Native as a dependency
Siobhan committedJun 26, 2023 Configuration menu - View commit details
-
Copy full SHA for 21a4fbe - Browse repository at this point
Copy the full SHA 21a4fbeView commit details -
Revert "[Temporary] Add React Native as a dependency"
This reverts commit 21a4fbe.
Siobhan committedJun 26, 2023 Configuration menu - View commit details
-
Copy full SHA for 6d1a1a3 - Browse repository at this point
Copy the full SHA 6d1a1a3View commit details
Commits on Jun 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 76fde7c - Browse repository at this point
Copy the full SHA 76fde7cView commit details -
Merge branch 'upgrade/react-native-0.71.8' into upgrade/react-native-…
…0.71-ios # Conflicts: # gutenberg # ios-xcframework/Podfile.lock
Configuration menu - View commit details
-
Copy full SHA for edf1e8c - Browse repository at this point
Copy the full SHA edf1e8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b9f2cf - Browse repository at this point
Copy the full SHA 3b9f2cfView commit details
Commits on Jul 3, 2023
-
Point RNReanimated to a custom branch to work around 2.17.0 issue
The issue is due to RNReanimated looking for react-native in the node_modules relative to its location, which is how most projects would be setup. Unfortunately, our projects is not standard. When running `pod install` or `pod update`, we'd get: ``` Installing RNReanimated 2.17.0 (was 2.9.1-wp-4) internal/modules/cjs/loader.js:934 throw err; ^ Error: Cannot find module 'react-native/package.json' Require stack: - /Users/gio/Developer/a8c/gutenberg-mobile/ios-xcframework/[eval] at Function.Module._resolveFilename (internal/modules/cjs/loader.js:931:15) at Function.resolve (internal/modules/cjs/helpers.js:113:19) at [eval]:1:9 at Script.runInThisContext (vm.js:134:12) at Object.runInThisContext (vm.js:310:38) at internal/process/execution.js:81:19 at [eval]-wrapper:6:22 at evalScript (internal/process/execution.js:80:60) at internal/main/eval_string.js:27:3 { code: 'MODULE_NOT_FOUND', requireStack: [ '/Users/gio/Developer/a8c/gutenberg-mobile/ios-xcframework/[eval]' ] } [!] Invalid `RNReanimated.podspec` file: no implicit conversion of nil into String. # from /var/folders/dq/cdqxvx3s5ps75564rpmb_dc00000gn/T/d20230627-89428-abwplk/RNReanimated.podspec:5 # ------------------------------------------- # reanimated_package_json = JSON.parse(File.read(File.join(__dir__, "package.json"))) > config = find_config() # assert_no_multiple_instances(config) # ------------------------------------------- ```
Configuration menu - View commit details
-
Copy full SHA for f0ce4ed - Browse repository at this point
Copy the full SHA f0ce4edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6632ac8 - Browse repository at this point
Copy the full SHA 6632ac8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74e82b6 - Browse repository at this point
Copy the full SHA 74e82b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5582572 - Browse repository at this point
Copy the full SHA 5582572View commit details -
Switch to using
use_react_native!
in XCFrameworkPodfile
Using only our custom specs, the build failed with ``` Multiple commands produce '/Users/gio/Developer/a8c/gutenberg-mobile/ios-xcframework/DerivedData/XCFrameworkScaffold/Build/Products/Debug-iphonesimulator/ReactCommon/ReactCommon.framework/Headers/CallbackWrapper.h' - Target 'ReactCommon' (project 'Pods') has copy command from '/Users/gio/Developer/a8c/gutenberg-mobile/ios-xcframework/Pods/ReactCommon/react/bridging/CallbackWrapper.h' to '/Users/gio/Developer/a8c/gutenberg-mobile/ios-xcframework/DerivedData/XCFrameworkScaffold/Build/Products/Debug-iphonesimulator/ReactCommon/ReactCommon.framework/Headers/CallbackWrapper.h' - Target 'ReactCommon' (project 'Pods') has copy command from '/Users/gio/Developer/a8c/gutenberg-mobile/ios-xcframework/Pods/ReactCommon/react/nativemodule/core/ReactCommon/CallbackWrapper.h' to '/Users/gio/Developer/a8c/gutenberg-mobile/ios-xcframework/DerivedData/XCFrameworkScaffold/Build/Products/Debug-iphonesimulator/ReactCommon/ReactCommon.framework/Headers/CallbackWrapper.h' ``` However, with this setup the build fails with: ``` /Users/gio/Developer/a8c/gutenberg-mobile/ios-xcframework/Pods/../../gutenberg/node_modules/react-native/React/FBReactNativeSpec/../../scripts/xcode/with-environment.sh: line 35: .xcode.env: command not found /Users/gio/Developer/a8c/gutenberg-mobile/ios-xcframework/Pods/../../gutenberg/node_modules/react-native/React/FBReactNativeSpec/../../scripts/xcode/with-environment.sh: line 35: node: command not found [Warning] You need to configure your node path in the environment. You can set it up quickly by running: echo 'export NODE_BINARY=' > .xcode.env in the ios folder. This is needed by React Native to work correctly. We fallback to the DEPRECATED behavior of finding . This will be REMOVED in a future version. You can read more about this here: https://reactnative.dev/docs/environment-setup#optional-configuring-your-environment /Users/gio/Developer/a8c/gutenberg-mobile/ios-xcframework/Pods/../../gutenberg/node_modules/react-native/React/FBReactNativeSpec/../../scripts/xcode/with-environment.sh: line 41: /scripts/find-node-for-xcode.sh: No such file or directory [Error] Could not find node. It looks like that the .xcode.env or .xcode.env.local ```
Configuration menu - View commit details
-
Copy full SHA for d065553 - Browse repository at this point
Copy the full SHA d065553View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbd6161 - Browse repository at this point
Copy the full SHA fbd6161View commit details -
Use
.xcode.env
instead of.xcode.env.local
This way, users can override what CocoaPods does without modifying the codebase via the `.local` file.
Configuration menu - View commit details
-
Copy full SHA for c7e2dd1 - Browse repository at this point
Copy the full SHA c7e2dd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f74c77 - Browse repository at this point
Copy the full SHA 8f74c77View commit details -
Use Xcode 14.3.1 in CI, like WordPress iOS does
Otherwise, we're getting a compilation failure. See wordpress-mobile/WordPress-iOS@eadad98#commitcomment-119894859
Configuration menu - View commit details
-
Copy full SHA for 28afd7f - Browse repository at this point
Copy the full SHA 28afd7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5919506 - Browse repository at this point
Copy the full SHA 5919506View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d6fd0a - Browse repository at this point
Copy the full SHA 1d6fd0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3326ab - Browse repository at this point
Copy the full SHA e3326abView commit details -
Configuration menu - View commit details
-
Copy full SHA for df511f2 - Browse repository at this point
Copy the full SHA df511f2View commit details -
Add workaround to setup Hermes correctly in XCFramework
They will take place if the process runs with `HERMES_ENABLED` true.
Configuration menu - View commit details
-
Copy full SHA for f2d999d - Browse repository at this point
Copy the full SHA f2d999dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 00052f5 - Browse repository at this point
Copy the full SHA 00052f5View commit details -
Embed Hermes XCFramework in Gutenberg XCFramework
This is so that, at runtime, apps can find it. Otherwise, the build will run but the app will fail at runtime with: ``` dyld[99988]: Library not loaded: @rpath/hermes.framework/hermes Referenced from: <931F58EC-3AC7-39DE-BEB7-1D44D8A5CF15> /Users/gio/Library/Developer/CoreSimulator/Devices/90F54127-B854-4ED8-93FA-D58167331941/data/Containers/Bundle/Application/3DA26EC7-B308-4029-9974-426839535542/WordPress.app/Frameworks/Gutenberg.framework/Gutenberg ```
Configuration menu - View commit details
-
Copy full SHA for b275a9d - Browse repository at this point
Copy the full SHA b275a9dView commit details
Commits on Jul 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ec0c7fa - Browse repository at this point
Copy the full SHA ec0c7faView commit details -
Merge branch 'upgrade/react-native-0.71.8' into mokagio/support-rn-0.…
…71.11-xcframework # Conflicts: # bin/generate-podspecs.sh # bundle/ios/App.js # bundle/ios/App.js.map # gutenberg # ios-xcframework/Podfile # ios-xcframework/Podfile.lock # third-party-podspecs/FBReactNativeSpec/FBReactNativeSpec.podspec.json # third-party-podspecs/hermes-engine.podspec.json
Configuration menu - View commit details
-
Copy full SHA for 17eae86 - Browse repository at this point
Copy the full SHA 17eae86View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bbb8b7 - Browse repository at this point
Copy the full SHA 3bbb8b7View commit details
Commits on Jul 5, 2023
-
3
Configuration menu - View commit details
-
Copy full SHA for 630b737 - Browse repository at this point
Copy the full SHA 630b737View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73249ba - Browse repository at this point
Copy the full SHA 73249baView commit details -
3
Configuration menu - View commit details
-
Copy full SHA for bdd6ab1 - Browse repository at this point
Copy the full SHA bdd6ab1View commit details