Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Tests - Adds more Highlight color visual tests #6830

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Apr 25, 2024

Adds two new visual tests to check the editor doesn't crash when using shorthand hex color codes with the highlight color feature:

  • should set a shorthand hex highlight color

For this test it sets theme data with a color containing the #000 value.

  • should render a mark tag with shorthand hex highlight color

This sets the initial content of the editor with a Paragraph block containing a mark tag (highlight formatting) with a #000 color.

This was addressed in Aztec Android wordpress-mobile/AztecEditor-Android#1079 so to prevent future issues these tests were added.

To test all CI checks should pass.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

…a shorthand hex code doesn't crash the app
@geriux geriux added the Testing Anything related to automated tests label Apr 25, 2024
@geriux geriux requested a review from twstokes April 25, 2024 12:34
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @geriux! 🚀

@geriux geriux merged commit 2467d43 into trunk Apr 25, 2024
24 checks passed
@geriux geriux deleted the add/highlight-color-e2e branch April 25, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Anything related to automated tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants