Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gbm CLI checklist includes clear directions #139

Closed
6 tasks done
dcalhoun opened this issue Jun 19, 2023 · 1 comment
Closed
6 tasks done

gbm CLI checklist includes clear directions #139

dcalhoun opened this issue Jun 19, 2023 · 1 comment
Labels
enhancement New feature or request [Feature] CLI

Comments

@dcalhoun
Copy link
Member

dcalhoun commented Jun 19, 2023

Currently, when generating a release checklist with the gbm CLI, there are a few typos, missing syntax parsing, or unnecessary conditional statements. We could address these to improve clarity.

Tasks

  1. derekblank
Screenshot Action
missed-interpolation Fix interpolation to display correct version number without extraneous characters.
missed-syntax-parsing Ensure Markdown code syntax is parsed. Replace usage of a separate Quote block with task text separated from task description by two new lines.
unnecessary-conditional-statement Given the template now adapts to the typeof release, we can remove the conditional prefix for tasks.
missing-zero-in-url Repair the GitHub Release link to include the required .0 in the release, tag, and branch names.
@jhnstn
Copy link
Member

jhnstn commented Oct 6, 2023

I believe most of the issues here were related to this

I've expanded the version verification to ensure there is always a patch value, even for .0. This seemed like the most efficient way to avoid surprises. I also don't think it's too much effort to type out the full release version.

The other issues were resolved in #146

@jhnstn jhnstn closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request [Feature] CLI
Projects
None yet
Development

No branches or pull requests

2 participants