Sniff FunctionCallSignatureSniff does not allow to override type in ruleset.xml

[martinssipenko]

Sniff FunctionCallSignatureSniff does not allow to override type in ruleset.xml because $type variable is set to private

[westonruter]

@martinssipenko sorry for the delay on this. Can you explain further what the problem is? Is the problem that you want to be able to extend WordPress_Sniffs_Functions_FunctionCallSignatureSniff but could not override the type? Well, you wouldn't be able to with your changes here either because you've also made it private.

[martinssipenko]

No, there is an option in phpcs to change message type from warning to error or vice-verse using ruleset.xml. Phpcs uses $type variable to achieve, which in this case is private and used for other purposes, so I just renamed to free up the $type. BTW I guess no sniffs should be using this variable, since it's reserved for phpcs.

[westonruter]

This was actually addressed in ca6ccd2