Support update of root object type #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
commented
Jun 26, 2022
Comment on lines
+81
to
+88
| } else if ( | ||
| object_root.constructor.$gtype !== object_preview.constructor.$gtype | ||
| ) { | ||
| object_root.destroy(); | ||
| setObjectRoot(object_preview); |
There was a problem hiding this comment.
@lw64 that's all there is to do
sonnyp
force-pushed
the
support-update-root-type
branch
from
1e59fa4
to
1069b91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59
When the new UI code would change the type of the root object - simply destroy the previous one and set the new root object.
From a UX perspective
If the previous object was a GtkRoot - the window is closed
If the new object isn't a GtkRoot - the new object is directly previewed in Workbench window
If the new object is a GTKRoot - user simply has to click on the primary button "Show Preview Window"