Library: Port 'Video' to Python #728
Conversation
| video.set_file(Gio.File.new_for_uri(workbench.resolve("./workbench-video.mp4"))) | ||
|
|
||
|
|
||
| def on_pressed(*_): |
There was a problem hiding this comment.
Not very sure if this is the best way - it gets 4 parameters that we don't care about
There was a problem hiding this comment.
*_ is a bit odd style, normally this is always called *args, but it's OK.
There was a problem hiding this comment.
But yeah this is kind of the way to go if you don't care about the signal's parameters.
There was a problem hiding this comment.
Let's be consistent with code style 🙏
@theCapypara you can document Python code style in https://github.com/sonnyp/Workbench/wiki/Style-Guide
There was a problem hiding this comment.
So should I change it to "args" or leave it as "_" to indicate that they are discarded?
There was a problem hiding this comment.
I know we already merged a few PRs with *_ but I would really prefer *args.
@sonnyp I'll do that later once the storm of demo PRs is done, I'll also see if we can add linting then, it would probably point this out.
There was a problem hiding this comment.
What about methods that have multiple discards like lambda _, __ should it become lambda *args? And what about lambda x, _, y, __?
There was a problem hiding this comment.
In the first case, yes. In the second you could do x, _a, y, _b if it's just one extra argument or also x, _a, y, *args in general.
No description provided.