Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop LLVM #916

Closed
wants to merge 1 commit into from
Closed

Drop LLVM #916

wants to merge 1 commit into from

Conversation

sonnyp
Copy link
Contributor

@sonnyp sonnyp commented Mar 23, 2024

Fixes #611

I tried to make mold work with gcc with -C link-arg=-fuse-ld=mold -C link-arg=-B=/usr/lib/sdk/rust-stable/ but it resulted in note: collect2: fatal error: cannot find 'ld'

Anyway, I can't see a difference with our without Mold - could it be the gnu linker is substantially faster now?

@Hofer-Julian wdyt?

@Hofer-Julian
Copy link
Contributor

I tried to make mold work

Mold stopped working?

I can't see a difference with our without Mold

You mostly notice see the difference with incremental builds.

could it be the gnu linker is substantially faster now?

Not that I would know

@sonnyp
Copy link
Contributor Author

sonnyp commented Mar 23, 2024

Mold stopped working?

No i meant that I tried to make mold work with gcc

You mostly notice see the difference with incremental builds.

I really don't but I must be missing something. How can I trigger it? I'll do some benchmarks with/without Mold

@Hofer-Julian
Copy link
Contributor

Hofer-Julian commented Mar 24, 2024

On my machine, I get the following results:
1.5 seconds for "Web View" with Mold
4 seconds for "Web View" with gold

A big difference in relative numbers, but both compile times are very acceptable.
If that makes your lives easier, I am fine with dropping Mold and LLVM.

@sonnyp sonnyp closed this Apr 15, 2024
@sonnyp sonnyp deleted the drop-llvm branch April 15, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop llvm
2 participants