Port 'Snapshot' demo to Vala #179
Conversation
Add initial Vala code for Snapshot Suggestion needed for the use of 'this' keyword
Usage of keyword according to Javascript and Python implementations
| private Gtk.GestureDrag gesture; | ||
| private bool gesture_started = false; | ||
|
|
||
| public Chessboard() { |
There was a problem hiding this comment.
Looks great overall! We are just missing the space before the parentheses and this is ready to be merged.
There was a problem hiding this comment.
The formatter from vala lang server automatically removes the space before the parentheses.
|
Hello again from me after this long time, I am extremely sorry I left everyone without help even though I was responsible... |
|
Also I support/trust all decisions @Diego-Ivan made, in this PR and everywhere else :) |
| private Gtk.GestureDrag gesture; | ||
| private bool gesture_started = false; | ||
|
|
||
| public Chessboard() { |
There was a problem hiding this comment.
The formatter from vala lang server automatically removes the space before the parentheses.
Add initial Vala code for Snapshot
-Used
thiskeyword according to Javascript and Python demos-Avoided
thiskeyword for constant valuesLet me know if the implementation is correct and also if there are any other fixes that need to be done :)