Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run xcmsSet on each input file individually #2

Closed
sneumann opened this issue Mar 16, 2016 · 25 comments
Closed

Run xcmsSet on each input file individually #2

sneumann opened this issue Mar 16, 2016 · 25 comments

Comments

@sneumann
Copy link
Contributor

Then Galaxy can parallelize the execution.
For backwards compatibility, check at
https://github.com/workflow4metabolomics/xcms/blob/master/src/xcms_w4m_script/xcms.r#L122
if a ZIP or an mzML/netCDF/... is provided.

Then you get one xcmsSet per input file.
After all N xcmsSets are created, use " c(xs1, xs2, xs3, ..." to combine
all individual xcmsSets into one big, like the existing node does.
Yours, Steffen

@lecorguille
Copy link
Member

We will be able to carry on new developments since planemo shed_test for all tools in this repo
#3

@lecorguille
Copy link
Member

Let's go!
#13

@lecorguille
Copy link
Member

In progress: #13
Need to be tested

@lecorguille
Copy link
Member

Available from the testtoolshed since the version 2.1.0
docker run -d -p 8080:80 quay.io/workflow4metabolomics/galaxy-workflow4metabolomics:beta

The CAMERA part will fail. I'm working on that workflow4metabolomics/camera.archive#15

@lecorguille lecorguille added this to the release_2.1.0 milestone Feb 10, 2017
@lecorguille
Copy link
Member

Available within the dev galaxy instance

@lecorguille
Copy link
Member

lecorguille commented Feb 24, 2017

Unfortunatly, we can't currently import CDF file in the dev instance because it need to be updated.
By can you try with some other format to:

  • launch as many xcmsSet as input file

  • merge the rdata with xcms.merger

  • launch the whole workflow until camera

  • validated by @melpetera

  • validated by @yguitton

  • validated by @jfrancoismartin

  • validated by @pierrickrogermele

@melpetera
Copy link
Member

melpetera commented Feb 24, 2017

Can't manage to make the merge work:

Tool execution generated the following error message:

Fatal error: Exit code 1 ()
Warning message:
'loadRcppModules' is deprecated.
Use 'loadModule' instead.
See help("Deprecated") 
Error in peaklist[[i]][, "sample"] : subscript out of bounds
Calls: c -> c.xcmsSet
Execution halted

The tool produced the following additional output:

	XSET MERGING...
QC_1 
QC_2 

@sneumann
Copy link
Contributor Author

Need more debugging information. The warning is from package mzR and Rcpp,
but should (?!) still work. If not, I need to add a sanity check to c.xcmsSet().
In which R file is this c(xs1, xs2, ...) called ?

@lecorguille
Copy link
Member

@melpetera I observed this behaviour when I merge MM8 and MM14 obtained with the default parameters of xcmsSet.
I got this kind of xset:

	XSET OBJECT INFO
An "xcmsSet" object with 1 samples

Time range: Inf--Inf seconds (Inf--Inf minutes)
Mass range: Inf--Inf m/z
Peaks: 0 (about 0 per sample)
Peak Groups: 0 
Sample classes: .

@lecorguille
Copy link
Member

@sneumann Here

@melpetera
Copy link
Member

Oh right! I didn't notice... I'll try to change my initial xcmsSet parameters.

@lecorguille
Copy link
Member

Meanwhile, I should raise and error because currently this kind of result is green

@melpetera
Copy link
Member

Now that my xcmsSet output files are good, the whole workflow works perfectly!

@lecorguille
Copy link
Member

ping at least @melpetera @yguitton

After some nocturnal reflections, I think I should simplified the form around the inputs.

Currently:

      <conditional name="inputs">
            <param name="input" type="select" label="Choose your inputs method" >
                <option value="zip_file" selected="true">Zip file from your history containing your chromatograms</option>
                <option value="single_file">mzXML file from your history</option>
            </param>
            <when value="zip_file">
                <param name="zip_file" type="data" format="no_unzip.zip,zip" label="Zip file" />
            </when>
            <when value="single_file">
                <param name="single_file" type="data" format="mzxml,netcdf" label="Single file" />
            </when>
      </conditional>

So users have to choose the input method between zip_file or single_file (mzxml, ...) and then to select their input in their history.
What do you think about accept in the same param both zip file and individual files?

<param name="file" type="data" format="no_unzip.zip,zip,mzxml,mzml,netcdf,mzdata" label="Single file" />

If you agree with that, unfortunatly, at some point, I will ask you to test again the whole workflow.

@lecorguille
Copy link
Member

Pong: @bgruening

@bgruening
Copy link
Contributor

ping! :)
I'm definitely in favor of the single input without a choice. So that you put everything in one format attribute. This should be a much better UX and less code :)
In a long run I would even try to remove the zip from the supported file types.

Stupid question what happens if in the zip are 10 files?

@lecorguille
Copy link
Member

Done: #44

Available within the dev galaxy instance

@lecorguille
Copy link
Member

@yguitton
The datatype netCDF and mzData are now supported within the galaxydev instance
Try again! :)

@melpetera
Copy link
Member

melpetera commented Mar 31, 2017

Tested on dev galaxy instance:

  • single input without a choice
  • Run xcmsSet on each input file individually
  • xcms.xcmsSet Merger
  • reaching fillPeaks from individual input files

@sneumann
Copy link
Contributor Author

Cool! What is the link to the dev galaxy instance ?

@yguitton
Copy link
Member

OK for xcmSet
OK single and multiple mzXML
OK for single & multiple CDF in a zip
OK for single & multiple mzData in a zip

Note still accent issue if some are present inside mzXML files

@lecorguille
Copy link
Member

lecorguille commented Mar 31, 2017

@sneumann The URL is https://galaxydev.workflow4metabolomics.org
If you have trouble to login, let me know :)

@lecorguille
Copy link
Member

Validated 👍
Thanks to my testers

@lecorguille
Copy link
Member

To really close this thread

Here is a little screencast about how to run in parallel xcmsSet within W4M using single files [link]

@jfrancoismartin
Copy link
Member

Sorry for the delay.
I made some mistakes in my tests...
Everything is ok for me now.

lecorguille added a commit that referenced this issue Jul 26, 2019
lecorguille added a commit that referenced this issue Jul 30, 2019
Add Metabolomics tag in Galaxy toolshed descriptions.
bernt-matthias pushed a commit to bernt-matthias/xcms that referenced this issue Oct 7, 2019
lecorguille added a commit that referenced this issue Feb 4, 2020
lecorguille pushed a commit that referenced this issue Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants