Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xcms_summary - upgrade CAMERA #182

Merged
merged 3 commits into from May 12, 2020
Merged

xcms_summary - upgrade CAMERA #182

merged 3 commits into from May 12, 2020

Conversation

lecorguille
Copy link
Member

@lecorguille lecorguille commented May 5, 2020 •
edited

Should fix this issue :

Fatal error: Exit code 1 ()
Error in chromPeaks(from)[, "is_filled"] : subscript out of bounds
Calls: getxcmsSetObject
Execution halted

Link to sneumann/xcms#466

bgruening
bgruening reviewed May 5, 2020
View reviewed changes
tools/xcms_summary/abims_xcms_summary.xml
@@ -1,4 +1,4 @@
<tool id="abims_xcms_summary" name="xcms process history" version="@TOOL_VERSION@+galaxy0">
<tool id="abims_xcms_summary" name="xcms process history" version="@TOOL_VERSION@+galaxy1">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not need to be bumped as you increase the TOOL_VERSION already.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OUhai, you are really quick. Impressive!

CAMERA isn't the main tool of this wrapper. It's XCMS.
Indeed, it can be confusing :/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I see ... Ok, sorry.

@lecorguille lecorguille merged commit 7234c5f into master May 12, 2020
@lecorguille lecorguille deleted the xcms_summary_update branch May 12, 2020 20:25
@melpetera melpetera mentioned this pull request Aug 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgruening bgruening bgruening left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lecorguille @bgruening