-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and clean-up #50
base: master
Are you sure you want to change the base?
Conversation
@PetrosPapapa It would in the long term. I did this by hand, as I had to read the code to understand it anyway. I can add the configuration for that tool as part of this PR, so that it is available for use in the future. |
I tried to configure scalafmt as best as I could. One issue I still have with the current configuration is with how it multilines long argument lists. For example:
is formatted as
which, in my opinion, is not an improvement. However, I don't know if there is a configuration option for this case, so we might have to live with this. |
While I am going through the code, I will do my best to clean it up and make it more readable. This includes adding documentation and comments where useful, renaming variables to reflect content, replacing tabs with spaces, indenting, ...