Add retryable http client and use in FGA module #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthadley
reviewed
Aug 6, 2024
kkajla12
reviewed
Aug 7, 2024
kkajla12
approved these changes
Aug 8, 2024
mthadley
approved these changes
Aug 12, 2024
This retryable client lives in a new `retryablehttp` package and implements a `Do` method that includes built-in retry logic. It implements exponential backoff and retries on request errors as well as 50X response codes.
The minimum delay time should be 250ms to account for the initial delay (500ms) with max negative jitter (250ms).
stanleyphu
force-pushed
the
feat/RetryableHttpClientInFGA
branch
from
7748dd1
to
9cae2d7
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
httpretryable.HttpClientwhich implements the.Domethod for making requests with built-in retry logic using exponential backoff.Replaces the http client in the FGA module to use the retryable http client
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.