This repository has been archived by the owner on Apr 7, 2024. It is now read-only.
Update review #42
Merged
Update review #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a relative path, img could not be found from 'http://localhost:8087/review/6'. From that URL, img path resolved to 'http://localhost:8087/review/img/compass.svg'. Changing to absolute fixes this.
added canAddReview and canUpdateReview functions and used them to block the relevant routes. Changed the sections using spaces to tabs. changed some request types (from post to put/delete). added db query to /profile route, made /update/:id get and put routes, and /delete/:id route.
This was
linked to
issues
Oct 10, 2020
Closed
|
Let me know if you have any questions or if I can do anything to make the changes clearer. Added quite a bit in this one. |
ankush
suggested changes
Oct 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves:
Will need to run
npm installto download themethod-overridemodule.