Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Certificates service with methods for interacting with revocation state. #30

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

SanjayVas
Copy link
Member

@SanjayVas SanjayVas commented May 27, 2021

This change is Reviewable

@SanjayVas
Copy link
Member Author

This is intended to be merged into main after the parent PR #29. It's related to world-federation-of-advertisers/cross-media-measurement#78.

Copy link
Contributor

@efoxepstein efoxepstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kungfucraig and @SanjayVas)


src/main/proto/wfa/measurement/api/v2alpha/certificates_service.proto, line 29 at r1 (raw file):

service Certificates {
  // Creates (adds) a `Certificate`.
  rpc CreateCertificate(CreateCertificateRequest) returns (Certificate) {}

OOC does clang-tidy let you use a semi-colon instead of {}? Seems a little clearer to me.

Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @efoxepstein and @kungfucraig)


src/main/proto/wfa/measurement/api/v2alpha/certificates_service.proto, line 29 at r1 (raw file):

Previously, efoxepstein (Eli Fox-Epstein) wrote…

OOC does clang-tidy let you use a semi-colon instead of {}? Seems a little clearer to me.

clang-format allows it. The {} syntax was copied from the gRPC and AIP docs. The brace syntax is needed if you're adding annotations to the method, which are needed for APIs that are served over HTTP. We should also add the other non-http API annotations such as field_behavior, but that can be done later.

Copy link

@zachcwc zachcwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @corbantek, @efoxepstein, @kungfucraig, and @oliver-amzn)

Copy link
Contributor

@efoxepstein efoxepstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @corbantek, @kungfucraig, and @oliver-amzn)

Base automatically changed from sanjayvas-resource-name to main June 1, 2021 16:44
@SanjayVas SanjayVas merged commit 77012ee into main Jun 1, 2021
@SanjayVas SanjayVas deleted the sanjayvas-certificates branch June 1, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants