-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define Certificates service with methods for interacting with revocation state. #30
Conversation
This is intended to be merged into main after the parent PR #29. It's related to world-federation-of-advertisers/cross-media-measurement#78. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kungfucraig and @SanjayVas)
src/main/proto/wfa/measurement/api/v2alpha/certificates_service.proto, line 29 at r1 (raw file):
service Certificates { // Creates (adds) a `Certificate`. rpc CreateCertificate(CreateCertificateRequest) returns (Certificate) {}
OOC does clang-tidy let you use a semi-colon instead of {}
? Seems a little clearer to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @efoxepstein and @kungfucraig)
src/main/proto/wfa/measurement/api/v2alpha/certificates_service.proto, line 29 at r1 (raw file):
Previously, efoxepstein (Eli Fox-Epstein) wrote…
OOC does clang-tidy let you use a semi-colon instead of
{}
? Seems a little clearer to me.
clang-format allows it. The {}
syntax was copied from the gRPC and AIP docs. The brace syntax is needed if you're adding annotations to the method, which are needed for APIs that are served over HTTP. We should also add the other non-http API annotations such as field_behavior
, but that can be done later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @corbantek, @efoxepstein, @kungfucraig, and @oliver-amzn)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @corbantek, @kungfucraig, and @oliver-amzn)
4ff58ea
to
439c633
Compare
This change is