Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug that enqueues Computations in ending stage. #1625

Merged
merged 2 commits into from
May 23, 2024

Conversation

renjiezh
Copy link
Contributor

@renjiezh renjiezh commented May 20, 2024

The PR is to fix issue #1626

@wfa-reviewable
Copy link

This change is Reviewable

Copy link
Member

@kungfucraig kungfucraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @emadlivani, @renjiezh, and @SanjayVas)


src/main/kotlin/org/wfanet/measurement/duchy/daemon/mill/MillBase.kt line 167 at r1 (raw file):

          "Failing computation due to too many failed ComputationStageAttempts.",
        )
        return

Can you add a test that exercises the bug and shows that this fixes it?

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind splitting all the bug details into a GitHub issue that's referenced by this PR?

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @emadlivani and @renjiezh)

Copy link
Contributor Author

@renjiezh renjiezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @emadlivani and @kungfucraig)


src/main/kotlin/org/wfanet/measurement/duchy/daemon/mill/MillBase.kt line 167 at r1 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

Can you add a test that exercises the bug and shows that this fixes it?

Test cases updated. The previous test cases acknowledged and allowed the enqueue behavior for failed computation. Now they are corrected.

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @emadlivani and @kungfucraig)

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @emadlivani, @kungfucraig, and @Marco-Premier)

Copy link
Member

@kungfucraig kungfucraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @emadlivani and @Marco-Premier)

@renjiezh renjiezh merged commit bfcdbcf into main May 23, 2024
4 checks passed
@renjiezh renjiezh deleted the renjiez-mill-bug-enqueue-end-stage branch May 23, 2024 17:38
ple13 pushed a commit that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants