Add wormhole middleware to wormchain #3234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misko9
requested review from
bruce-riley,
hendrikhofstadt and
conorpp
as code owners
nik-suri
reviewed
Jul 25, 2023
…dleware governance vaas
middleware memo field.
GatewayTransfer/GatewayTransferWithPayload
WORMCHAIN_WASM_INSTANTIATE_ALLOWLIST_ACTION_ADD and IBC_UPDATE_CHANNEL_CHAIN_MODULE_RECEIVER.
felix-asym
reviewed
Aug 7, 2023
| // It is the hex representation of "IbcReceiver" left padded with zeroes. | ||
| var IbcReceiverModule = [32]byte{ | ||
| 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, | ||
| 0x00, 0x00, 0x00, 0x00, 0x00, 0x49, 0x62, 0x63, 0x52, 0x65, 0x63, 0x65, 0x69, 0x76, 0x65, 0x72, | ||
| } | ||
| var IbcReceiverModuleStr = string(IbcReceiverModule[:]) | ||
|
|
||
| // IbcTranslatorModule is the identifier of the Wormchain ibc_receiver contract module (which is used for governance messages) | ||
| // It is the hex representation of "IbcReceiver" left padded with zeroes. |
There was a problem hiding this comment.
Comment should say "IbcTranslator"
felix-asym
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a stacked PR and includes #3232 and #3233. Comments regarding x/ibc-hooks should be in #3232. Comments regarding PFM should be in #3233.
Comments regarding wormhole-mw, app.go integration, and wormhole module/VAA changes belong here.