Feature: three r77 upgrade #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out the render count WebGL spam that appears in the browser console is because the 'root' mesh in every M2 has no material associated with it, and thus isn't renderable. At some point, we should really revisit how the geometry and meshes in M2s are handled. There probably is no purpose for the root mesh.
|
This requires the changes made here be merged: wowserhq/blizzardry#95 |
|
Looks ace 👍 Will merge once the other one is merged. |
|
🎉 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Say hello to three.js r77 (upgraded from r73).
Two sources of WebGL console spam should now be gone: both the messages about textures not being assigned to a texture unit, and messages about render count being 0 should no longer appear.
Covers #133