Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Item] Fix Stay of Execution to actually reduce dmg taken #1049

Merged
merged 1 commit into from
Sep 22, 2024
Merged

[Item] Fix Stay of Execution to actually reduce dmg taken #1049

merged 1 commit into from
Sep 22, 2024

Conversation

hillerstorm
Copy link
Contributor

No description provided.

NerdEgghead
NerdEgghead approved these changes Sep 22, 2024
View reviewed changes
Copy link
Contributor

@NerdEgghead NerdEgghead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! There are a few things we'll still have to verify on PTR, such as whether the buff always lasts the full 30 seconds vs. the DoT starting to tick as soon as the absorb gets capped, but this is good enough as a first implementation.

@hillerstorm hillerstorm merged commit d771853 into wowsims:master Sep 22, 2024
3 checks passed
@hillerstorm hillerstorm deleted the fix_stay_of_execution branch September 22, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NerdEgghead NerdEgghead NerdEgghead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hillerstorm @NerdEgghead