Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builder + finisher combat rotation options #2825

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

vigo2
Copy link
Contributor

@vigo2 vigo2 commented Mar 27, 2023

[rogue] combat now allows to choose Backstab as alternative builder; fixed Backstab's ActionID
[rogue] also add back the "rupture-less" rotation (with finisher priority "Eviscerate")
[rogue] when about to waste a CP, combat now allows to clip a up to 4.5s of SnD uptime
[rogue] added some additional warnings (e.g. when using "In Front of Target" with Backstab or Garrote)

"Fixes" #2785 and #2742

…fixed Backstab's ActionID

[rogue] when about to waste a CP, combat now allows to clip a up to 4.5s of SnD uptime
[rogue] added some additional warnings (e.g. when using "In Front of Target" with Backstab or Garrote)
@vigo2 vigo2 requested review from b-r-a-n and catszeid March 27, 2023 22:18
Copy link
Contributor

@catszeid catszeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the work!

@vigo2 vigo2 merged commit edcd593 into wowsims:master Mar 28, 2023
@vigo2 vigo2 deleted the vigo/allowBackstab branch March 28, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants