Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update so crit debuffs do not stack for spells #3736

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

lime-green
Copy link
Contributor

Blizzard closed ClassicWoWCommunity/cata-classic-bugs#770 as not a bug, since this behaviour matches reference behaviour. Therefore spell crit debuffs cannot stack

@lime-green lime-green merged commit 61465a9 into wowsims:master Sep 23, 2023
2 checks passed
lime-green added a commit to lime-green/wow-sims-wotlk that referenced this pull request Sep 23, 2023
lime-green added a commit that referenced this pull request Sep 23, 2023
* Revert "fix crit stat in UI (#3738)"

This reverts commit 6ed2bd8.

* Revert "update so crit debuffs do not stack for spells (#3736)"

This reverts commit 61465a9.

* add 3% spell crit suppression

* update fixed 5% guardians

* update numbers to match in-game tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 5% and 3% crit debuff are not stacking
1 participant