1.0.6 #17
Merged
1.0.6 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires something different. Should we use TCP instead?
HenryQuan
commented
Sep 23, 2023
| if (localServer != null) | ||
| { | ||
| localServer.Stop(); | ||
| } |
There was a problem hiding this comment.
We can potentially improve things here.
| /// Call <seealso cref="ValidatePath(string)"/> first to valid the path. | ||
| /// </summary> | ||
| /// <param name="gamePath">The game path from the TextBox</param> | ||
| public void EnableReplay(string gamePath) |
There was a problem hiding this comment.
Not sure if this is still needed. Replay should be enabled by default now in 2023.
| Console.WriteLine(ex.Message); | ||
| break; | ||
| } | ||
| isGettingData = false; |
There was a problem hiding this comment.
Need to test isGettingData properly tomorrow.
| /// <param name="name">The name of the entry</param> | ||
| /// <param name="port">The port number</param> | ||
| /// <exception cref="Exception">This can throw lots of exception, treat any as an error.</exception> | ||
| public void AddPortToFirewall(string name, int port) |
There was a problem hiding this comment.
This can be marked as deprecated now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #16
Now, I need to test it with my Android build and fix the permission issue on iOS.