-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Unit Testing Setup Steps For Windows !! #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to address about Bash on Ubuntu on Windows?
unittesting-windows.md
Outdated
|
||
The purpose of this discussion is to perfectly set up WP Unit Testing environment in a local project. Followed through https://make.wordpress.org/cli/handbook/plugin-unit-tests/ but it lacks some points when it comes to windows with addition to some general points missing. | ||
|
||
First, some commands in wp-cli doesnt work with windows, so use cygwin or alike command line utility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/does/doesn't/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cygwin/Cygwin/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- doesn't
- Cygwin
unittesting-windows.md
Outdated
|
||
For ease of understanding, I rewrite the points of above mentioned tutorial, such as ... | ||
|
||
2) Generate the plugin test files: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't 1)
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the 1) is ....
- If scaffold command fails, update to stable version (wp cli update --nightly)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh sorry, I mistaken ! There is no 1), the 2. relates second point of the original tutorial which I have mentioned right there in the second paragraph. So yes, there isn't the 1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion:
- I felt uncomfortable that there is
2)
but not1)
, it is my personal impression. - It will be better to add about "Ubuntu on Windows".
But I am not sure. 😄
@ronaksampat @miya0001 What do you think about incorporating this into the existing unit testing document, instead of creating a new one? |
+1 |
Hey @daniel ... hey @miyauchi I am completely fine for merging it to an
existing tutorial ... sorry I couldn't reply to you both quickly .....
kindly guide me what I have to do to merge it to an existing tutorial .....
I bet this will make that tutorial perfect !!
…On Thursday, August 3, 2017, Takayuki Miyauchi ***@***.***> wrote:
incorporating this into the existing unit testing document
+1
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#103 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AcgCCAytS7M3HILB-aUVhey5UCMLJYzqks5sUd_2gaJpZM4OnSE7>
.
--
Thank You,
Regards,
Ronak Sampat,
PHP & WordPress Developer.
www.multidots.com | contact : 9724445134
Email Id: ronak.sampat@m
ultidots.com <disha.vaishnav@multidots.com>
|
Edit the existing Plugin Unit Tests document and add a "Running tests on Windows" section to the bottom of the document. |
Thanks for your work on this @ronaksampat. I've merged it into the existing document and cleaned it up a bit. |
Hey @danielbacchuber, thanks for merging this @
https://github.com/wp-cli/handbook/blob/master/plugin-unit-tests.md. I
checked the mail but couldn't reply as I was on a holiday trip with
family!! Though there is not exactly as per what I had written in pull
request to be added but still looks quite informative, I am sure you would
have surely thought of all the aspects. Ask me if I need to edit in this
above mentioned original tutorial, I see I don't have the write access to
the above mentioned original but still is there a way for me to edit?
A little more question out of the curiosity, will there be my name in the
contributors list above or its for the contributors having the write access
only ? Its just a question out of curiosity, please don't mind it, hehe !!
Again, this is a very nice experience and thanks for your appreciation. You
people are doing great job and quite responsive. When I have time, I would
surely touch other things of this amazing project for sure especially as
now I am the part of this community !!
…On Mon, Aug 7, 2017 at 11:42 PM, Daniel Bachhuber ***@***.***> wrote:
Merged #103 <#103>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#103 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AcgCCLnb9ehomC3WXi_DSSRsIMy5U1sSks5sV1OngaJpZM4OnSE7>
.
--
Thank You,
Regards,
Ronak Sampat,
PHP & WordPress Developer.
www.multidots.com | contact : 9724445134
Email Id: ronak.sampat@m
ultidots.com <disha.vaishnav@multidots.com>
|
See https://help.github.com/articles/editing-files-in-your-repository/
I see your name on the list:
Happy to help! |
Added Unit Testing Setup Steps For Windows !!
Hello Folks, In this pull request, I have documented the steps that are useful to successfully implement the WP Unit Testing Framework to the WordPress project in Windows Environment!! My attempt is to help those people who are facing some issues in implementing this very useful testing environment in Windows.