Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Unit Testing Setup Steps For Windows !! #103

Merged
merged 4 commits into from
Aug 7, 2017

Conversation

ronaksampat
Copy link

@ronaksampat ronaksampat commented Jul 29, 2017

Hello Folks, In this pull request, I have documented the steps that are useful to successfully implement the WP Unit Testing Framework to the WordPress project in Windows Environment!! My attempt is to help those people who are facing some issues in implementing this very useful testing environment in Windows.

Copy link
Member

@miya0001 miya0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to address about Bash on Ubuntu on Windows?


The purpose of this discussion is to perfectly set up WP Unit Testing environment in a local project. Followed through https://make.wordpress.org/cli/handbook/plugin-unit-tests/ but it lacks some points when it comes to windows with addition to some general points missing.

First, some commands in wp-cli doesnt work with windows, so use cygwin or alike command line utility.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/does/doesn't/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cygwin/Cygwin/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. doesn't
  2. Cygwin


For ease of understanding, I rewrite the points of above mentioned tutorial, such as ...

2) Generate the plugin test files:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't 1), right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the 1) is ....

  1. If scaffold command fails, update to stable version (wp cli update --nightly)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh sorry, I mistaken ! There is no 1), the 2. relates second point of the original tutorial which I have mentioned right there in the second paragraph. So yes, there isn't the 1)

Copy link
Member

@miya0001 miya0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion:

  • I felt uncomfortable that there is 2) but not 1), it is my personal impression.
  • It will be better to add about "Ubuntu on Windows".

But I am not sure. 😄

@miya0001 miya0001 requested a review from a team August 2, 2017 13:42
@danielbachhuber
Copy link
Member

@ronaksampat @miya0001 What do you think about incorporating this into the existing unit testing document, instead of creating a new one?

@miya0001
Copy link
Member

miya0001 commented Aug 3, 2017

incorporating this into the existing unit testing document

+1

@ronaksampat
Copy link
Author

ronaksampat commented Aug 3, 2017 via email

@danielbachhuber
Copy link
Member

kindly guide me what I have to do to merge it to an existing tutorial .....

Edit the existing Plugin Unit Tests document and add a "Running tests on Windows" section to the bottom of the document.

@danielbachhuber
Copy link
Member

Thanks for your work on this @ronaksampat. I've merged it into the existing document and cleaned it up a bit.

@danielbachhuber danielbachhuber merged commit 5ae2bd0 into wp-cli:master Aug 7, 2017
@ronaksampat
Copy link
Author

ronaksampat commented Aug 8, 2017 via email

@danielbachhuber
Copy link
Member

I see I don't have the write access to
the above mentioned original but still is there a way for me to edit?

See https://help.github.com/articles/editing-files-in-your-repository/

A little more question out of the curiosity, will there be my name in the
contributors list above or its for the contributors having the write access
only ? Its just a question out of curiosity, please don't mind it, hehe !!

I see your name on the list:

image

Again, this is a very nice experience and thanks for your appreciation. You
people are doing great job and quite responsive.

Happy to help!

schlessera pushed a commit that referenced this pull request Jan 25, 2022
Added Unit Testing Setup Steps For Windows !!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants