Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thumbnail size is missing from registered image sizes #2

Closed
danielbachhuber opened this issue Mar 21, 2017 · 0 comments
Closed

Thumbnail size is missing from registered image sizes #2

danielbachhuber opened this issue Mar 21, 2017 · 0 comments
Labels
bug command:media command:media-regenerate
Milestone
1.0.1

Comments

@danielbachhuber
Copy link
Member

We need to include thumbnail (and other non-intermediate image sizes) in the following check:

if ( array_diff( get_intermediate_image_sizes(), array_keys( $metadata['sizes'] ) ) ) {
	return true;
}

Original report: wp-cli/wp-cli#3859
@danielbachhuber danielbachhuber mentioned this issue Mar 21, 2017
Closed
ivankruchkoff pushed a commit to ivankruchkoff/media-command that referenced this issue Mar 23, 2017
Fix wp-cli#2 as thumbnail sizes may be missing due to smaller image d…
a23dfda 
…imensions
This was referenced Apr 3, 2017
Merged
Merged
schlessera pushed a commit that referenced this issue Apr 6, 2017
@gitlost
Tests for Fix #2.
eb05844
schlessera added a commit that referenced this issue Apr 6, 2017
@schlessera
Merge pull request #5 from gitlost/Fix-#2-tests
2b28eb2 
Tests for Fix #2.
@danielbachhuber danielbachhuber added this to the 1.0.1 milestone Apr 6, 2017
danielbachhuber pushed a commit that referenced this issue Nov 18, 2022
@gitlost
Tests for Fix #2.
35eb927
danielbachhuber pushed a commit that referenced this issue Nov 18, 2022
@schlessera
Merge pull request #5 from gitlost/Fix-#2-tests
2466217 
Tests for Fix #2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug command:media command:media-regenerate
Projects
None yet
Milestone
1.0.1
Development

No branches or pull requests
1 participant
@danielbachhuber