Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table padding for accented characters #53

Merged
merged 2 commits into from
Jun 29, 2014
Merged

Fix table padding for accented characters #53

merged 2 commits into from
Jun 29, 2014

Conversation

danielbachhuber
Copy link
Member

Is it misaligned because of the accented characters?

| fv_clean_trash_hourly               | 2014-05-23 16:57:53 | 44 minutes 21 seconds | 1 óra               |
| qs_cron_hook                        | 2014-05-23 17:12:05 | 58 minutes 33 seconds | 1 óra               |
| wp_maybe_auto_update                | 2014-05-23 18:06:00 | 1 óra 52 minutes     | 12 óra              |
| wp_scheduled_delete                 | 2014-05-23 19:07:38 | 2 óra 54 minutes     | 1 nap                |
| alo_em_schedule                     | 2014-05-23 19:40:22 | 3 óra 26 minutes     | 12 óra              |

@szepeviktor
Copy link
Author

php -r 'echo strlen("óra");'
4
php -r 'echo mb_strlen("óra", "UTF-8");'
3

https://github.com/jlogsdon/php-cli-tools/blob/master/lib/cli/Colors.php#L181

@szepeviktor
Copy link
Author

wp-cli/wp-cli#1219

@szepeviktor
Copy link
Author

Is there any update on this?

@danielbachhuber danielbachhuber added this to the 0.9.5 milestone Jun 29, 2014
Introduces tests to the project.
@danielbachhuber danielbachhuber changed the title table padding Fix table padding for accented characters Jun 29, 2014
danielbachhuber added a commit that referenced this pull request Jun 29, 2014
Fix table padding for accented characters
@danielbachhuber danielbachhuber merged commit 48bb9ad into master Jun 29, 2014
@danielbachhuber danielbachhuber deleted the fix-53 branch June 29, 2014 19:54
@szepeviktor
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants