add couple of array value #45
Conversation
src/Scaffold_Command.php
Outdated
| @@ -902,16 +902,19 @@ private function pluralize( $word ) { | |||
| '/$/' => 's' | |||
| ); | |||
|
|
|||
| $uncountable = array( 'equipment', 'information', 'rice', 'money', 'species', 'series', 'fish', 'sheep' ); | |||
|
|
|||
| $uncountable = array('sheep', 'fish','deer','series','species','money','rice','information','equipment'); | |||
There was a problem hiding this comment.
@Umangvaghela While you're working on this, can you please update this as per WordPress' coding standards?
- Space after
, - Space after
(and before)
More details about coding standards can be found here -
https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/
src/Scaffold_Command.php
Outdated
| 'man' => 'men', | ||
| 'tooth' => 'teeth', | ||
| 'person' => 'people', | ||
| 'valve' => 'valves' |
There was a problem hiding this comment.
Last array item must end with a ,
|
Hi @Sidsector9 I have added a patch to remove white space issue to use PHP editor. |
|
Thanks for PR! Can you recover the sort order of elements? We have to check every element. 😓 |
src/Scaffold_Command.php
Outdated
| @@ -902,15 +902,18 @@ private function pluralize( $word ) { | |||
| '/$/' => 's' | |||
| ); | |||
|
|
|||
| $uncountable = array( 'equipment', 'information', 'rice', 'money', 'species', 'series', 'fish', 'sheep' ); | |||
| $uncountable = array( 'sheep', 'fish', 'deer', 'series', 'species', 'money', 'rice', 'information', 'equipment' ); | |||
There was a problem hiding this comment.
Please recover sort order of the elements.
There was a problem hiding this comment.
@miya0001
$uncountable = array( 'sheep', 'fish', 'deer', 'series', 'species', 'money', 'rice', 'information', 'equipment' );
do you want this form
$uncountable = array( 'deer','equipment', 'fish' , 'information', 'money', 'rice', 'series', 'sheep', 'species' );
There was a problem hiding this comment.
@Umangvaghela what @miya0001 meant is that don't change the order of the default array. If you want to add new elements then add it to the end of the array.
src/Scaffold_Command.php
Outdated
|
|
||
| $irregular = array( | ||
| 'person' => 'people', |
There was a problem hiding this comment.
Please recover sort order of the elements.
|
Anyway, is this pattern is finite? |
|
Oh, I apologize for lack of explanation in this topic. Actually, we are really appreciate you, but I want to find the best way to solve the problem. Thanks! |
add couple of array value