Grunt i18n: unused var, ignored dirs #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two additional notes (not in this PR):
|
diggy
changed the title
I think it is not important for now. Thanks! |
danielbachhuber
pushed a commit
that referenced
this pull request
Nov 18, 2022
Grunt i18n: unused var, ignored dirs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bannervariable ('banner' is assigned a value but never used.).gitdirphp-tests>tests)Negating globbing patterns in
addtextdomain.update_all_domainswork but do not seem to have any effect on the makepot task (reproducible by putting a php file with a__()call in e.g.binand runninggrunt i18n --verbose). Adding anexcludeparam to themakepottask seems to be the only way to have the dirs and files within them effectively ignored.