Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite: Support custom wp-content directory #188

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

swissspidy
Copy link
Member

Some other commands' tests have tests using a custom wp-content directory. This change ensures those tests pass when running with SQLite.

Adds test coverage.

@swissspidy swissspidy added this to the 2.4.2 milestone Oct 23, 2023
@swissspidy swissspidy requested a review from a team as a code owner October 23, 2023 16:55
@schlessera
Copy link
Member

@swissspidy Wouldn't it be more correct to actually activate the SQLite plugin instead? This way we wouldn't need custom hard-coded logic like the above, and we'd get any future extra steps for free. Is there a reason why we're not activating the plugin right now?

@swissspidy
Copy link
Member Author

I thought about that, but:

  • The drop-in needs to work even before install and before the plugin is activated
  • The drop-in actually automatically activates the plugin if it's not yet active. See source
  • This change here is still needed, because the drop-in has a hardcoded path to the main plugin file. So if you change the location of WP_PLUGIN_DIR, that string needs to be updated, which is what this PR achieves.

@schlessera schlessera merged commit 560ed5c into main Oct 24, 2023
41 checks passed
@schlessera schlessera deleted the fix/sqlite-custom-wp-content branch October 24, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants