This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
Release/v0.5.0 #250
Merged
Release/v0.5.0 #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
found typo in line 1738. "assinged" => "assigned"
This is the fix of this issue: #44
#213 - fix the Github Plugin URI
fix plug-in URI to support github plugin updater
Replace depricated acf_get_term_post_id() function
Fix problem with return value of select format
Update README.md
…s in Github actions when Pull Requests are opened. - Updates test for range field to assert it's a float
Update CI Environment for tests
- update app.entrypoint - update Dockerfile to install zip/unzip and pcov
- update testing.Dockerfile
Update test environment
Readme and the example json
…lowed WP convention for new code
Update to xdebug 3 config and add ability to build app docker with xdebug
# Conflicts: # docker/app.entrypoint.sh
…ld Group page - Add Ajax callback for determining rules - Update Location Rules to check for rule conflicts, and support many edge cases, such as assigning a Field Group to a post_status - Update JS helpers for the GraphQL Field Group settings. Add conditional logic to the field that allows users to manually chose GraphQL fields or map based on location rules - Reset location rules when manual graphql type mapping is unchecked.
- add support for new location rules to map to options pages - check to see if field group is set to be manually mapped to GraphQL Types, and if so, don't use get_location_rules() to automatically map when building the Schema - Add test for ACF settings pages and ACF sub settings pages
- back out the change to remove the prefix from field groups (will be addressed later)
Fix #135. Add Explicit options for adding ACF Field Groups to the Schema
This was referenced Apr 20, 2021
…est if one is not already pending.
markkelnar
reviewed
Apr 22, 2021
| @@ -4,7 +4,7 @@ Donate link: https://wpgraphql.com/acf | |||
| Tags: WPGraphQL, GraphQL, API, Advanced Custom Fields, ACF | |||
| Requires at least: 5.0 | |||
| Tested up to: 5.1.1 | |||
| Stable tag: 0.4.1 | |||
| Stable tag: 0.5.0 | |||
There was a problem hiding this comment.
Since this is significant breaking changes, should you put something in the readme description or add an 'upgrade notice' section? See https://wordpress.org/plugins/readme.txt
There was a problem hiding this comment.
Since the plugin isn't distributed on WordPress.org (yet) I've been handling all my communication in Github releases.
Once we hit 1.0 and distribute on the .org repo, we'll use this README much more actively like I'm doing for WPGraphQL
This shouldn't actually cause breaking changes either. It's for sure possible, but the tests we did have show that the location rules that used to work still work, and added more coverage for additional location rules.
I bumped it from 0.4.1 to 0.5.0 because it is significant changes, but should still be non-breaking.
markkelnar
reviewed
Apr 22, 2021
…e array - Update get_rules() method to early return quicker - Update main.js to trigger the change after check/uncheck has occurred, not only when checking has occurred
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
This release focuses primarily on Location Rules and how ACF Field Groups are mapped to the WPGraphQL Schema.
Bugfixes / Chores
acf_get_term_post_id()method. Thanks @sboerrigter!New Features / Big Changes
LOCATION, LOCATION, LOCATION!!!
This release primarily addresses issues related to Field Group location rules and adding field groups to the GraphQL Schema.
Prior to this release, ACF Field Groups were added to the GraphQL Schema strictly by analyzing the ACF Location Rules for the field group(s) and attempting to map the field group to the Schema.
Some rules are quite nuanced and hard to translate, and in some cases this meant that the Field Group would simply not show up in the Schema, or in other cases the field group wouldn't show exactly where you wanted.
This release brings a new way of mapping ACF Field Groups to the WPGraphQL Schema.
It still uses ACF Location Rules to try and "guess" where in the Schema the field group should show, but now it shows you where it will be and allows you to opt-out of the auto-mapping and set the GraphQL Types the field group should show on manually.
🎥 👉 This video walks through this new functionality: https://youtu.be/VvrZGrcwv0Y
Closes the following issues:
📣 HUGE shout out to @drewbaker @rsm0128 and @funkhaus for putting a lot of time and energy into Location Rule revamp. Would not be where it is without your work!!! 🙌🏻