Fix term arrays for ID & TAXONOMY_ID #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When querying by field ID or TAXONOMY_ID the results were incorrect because it was only using the last element in the original array
guvkon
approved these changes
Jun 16, 2021
|
Any chance we can this merged and a new release pushed out? I just got bit by this on a project and found this bug, but when I went to submit a pull request for the fix, I saw that this had already been submitted and approved. |
|
@jasonbahl could you please merge this? |
jasonbahl
approved these changes
Nov 8, 2022
|
🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querying by field ID or TAXONOMY_ID the results were incorrect because it was only using the last element in the original array
example:
The following will only show posts that are in Category id 30 (it doesn't show those in 10 or 20)
posts( where: { taxQuery: { relation: AND taxArray: [ { terms: [10, 20, 30], field: ID, taxonomy: CATEGORY, operator: IN } ] } } )