Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/global autoloader support #524

Merged

Conversation

kidunot89
Copy link
Member

@kidunot89 kidunot89 commented Jul 6, 2021

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

Does this close any currently open issues?

#525

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version: v0.10.1
  • WPGraphQL Version: v1.5.0
  • WordPress Version:
  • WooCommerce Version:

@kidunot89 kidunot89 added the bugfix Implements bugfix label Jul 6, 2021
@kidunot89 kidunot89 requested a review from jasonbahl July 6, 2021 16:26
@kidunot89 kidunot89 self-assigned this Jul 6, 2021
@kidunot89 kidunot89 force-pushed the bugfix/global-autoloader-support branch from 7b436f3 to f8b3e57 Compare July 6, 2021 22:54
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8725 lines exceeds the maximum allowed for the inline comments feature.

@kidunot89 kidunot89 force-pushed the bugfix/global-autoloader-support branch from f8b3e57 to 09fdd4c Compare July 6, 2021 23:51
@codeclimate
Copy link

codeclimate bot commented Jul 7, 2021

Code Climate has analyzed commit 09fdd4c and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Style 1
Bug Risk 1

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 77.1% (-0.1% change).

View more on Code Climate.

@kidunot89 kidunot89 merged commit a702bee into wp-graphql:develop Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Implements bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant