Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:feat: Update banner price #793

Merged
merged 2 commits into from
Feb 12, 2024
Merged

:feat: Update banner price #793

merged 2 commits into from
Feb 12, 2024

Conversation

Khadreal
Copy link
Contributor

@Khadreal Khadreal commented Feb 2, 2024

Description

Update banner price

Fixes #2658

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Is the solution different from the one proposed during the grooming?

No

Please describe in this section if there is any change to the groomed solution, and why.

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

If not, detail what you could not test.

Please describe any additional tests you performed.

@Mai-Saad
Copy link

Mai-Saad commented Feb 9, 2024

Working as expected on the branch
Screenshot from 2024-02-09 12-09-46

@Mai-Saad Mai-Saad added this pull request to the merge queue Feb 12, 2024
Merged via the queue into develop with commit 431a4ff Feb 12, 2024
7 checks passed
@Mai-Saad Mai-Saad deleted the update-banner#2658 branch February 12, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants