-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #23: Add tests to increase coverage of 3.17 #27
Closes #23: Add tests to increase coverage of 3.17 #27
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Thanks for the first tests @jeawhanlee 🙏 See the coverage report for more details: https://app.codacy.com/gh/wp-media/rocket-scripts/coverage/files/123936609510 |
@wp-media/engineering-plugin-team Since @jeawhanlee is off today, I am bringing this back to ToDo so that someone can pick it up and consider the above comment: should we cover some of the private methods too? And if yes, add some coverage to the relevant methods. |
I believe we can add small direct tests for those mentioned methods like |
That PR is taking more than expected with me because the current PR tests depending on mocking the methods using prototypes so no way to test those methods that way because if we mocked a method in one test, we can't remove this mock in the next test to validate the base method code. |
…crease-coverage-of-3.17 # Conflicts: # src/BeaconLrc.js
Description
Fixes #23
Add tests for the LRC beacon to increase coverage.
Type of change
Detailed scenario
N/A
Technical description
Documentation
Add unit tests for LRC beacon
New dependencies
N/A
Risks
N/A
Mandatory Checklist
Code validation
Code style
Additional Checks