Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elementor maintenances mode & wp rocket cache #4937

Closed
Michaelgimii opened this issue Apr 15, 2022 · 5 comments · Fixed by #5800
Closed

elementor maintenances mode & wp rocket cache #4937

Michaelgimii opened this issue Apr 15, 2022 · 5 comments · Fixed by #5800
Assignees
Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: cache noQA priority: low Issues that can wait type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Milestone

Comments

@Michaelgimii
Copy link

Describe the bug

When enabling elementary maintenances mode, we must clear the wp rocket cache to apply the maintenances mode. Please resolve this issue.
In such a way that after activating the maintenances mode, it is applied immediately and there is no need to clear the cache. The current situation is very annoying. Many times we activate the maintenances mode and forget to clear the cache. Therefore, maintenances mode is not enabled for users.
Maintenances mode will not be applied until we clear the cache.

@piotrbak piotrbak added 3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: cache priority: low Issues that can wait type: enhancement Improvements that slightly enhance existing functionality and are fast to implement labels Apr 18, 2022
@Michaelgimii
Copy link
Author

Are there any plans to fix this?

@DahmaniAdame
Copy link
Contributor

DahmaniAdame commented Mar 8, 2023

@piotrbak hooking to elementor/maintenance_mode/mode_changed to the Elementor compatibility file to trigger clear_cache.

https://github.com/elementor/elementor/blob/fab0d46aac98a4b09a92b7a0a7bf4fcbe1942b46/includes/maintenance-mode.php#L317

Added a PR for it.

@Michaelgimii you can use the following code on your functions file as a temporary fix:

add_action("elementor/maintenance_mode/mode_changed", function () {
    if (function_exists("rocket_clean_domain")) {
        rocket_clean_domain();
    }
});

@DahmaniAdame
Copy link
Contributor

@piotrbak any update on this one?

@piotrbak
Copy link
Contributor

@DahmaniAdame Thanks, I missed your comment. I'll add it to the sprint as the change is ready.

@Michaelgimii
Copy link
Author

Michaelgimii commented May 8, 2023

@Michaelgimii you can use the following code on your functions file as a temporary fix:

add_action("elementor/maintenance_mode/mode_changed", function () {
    if (function_exists("rocket_clean_domain")) {
        rocket_clean_domain();
    }
});

thanks @DahmaniAdame

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: cache noQA priority: low Issues that can wait type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants