Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In case rocket_atf_warmup_links filter is given a wrong input, the fetch mechanism should default to 10 URLs + home #6576

Closed
hanna-meda opened this issue Apr 19, 2024 · 0 comments · Fixed by #6580
Assignees
Labels
effort: [XS] < 1 day of estimated development time priority: low Issues that can wait severity: minor Defect that does not affect functionality type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Milestone

Comments

@hanna-meda
Copy link

hanna-meda commented Apr 19, 2024

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version 3.16-alpha1 ✓
  • Used the search feature to ensure that the bug hasn’t been reported before ✓

Describe the bug
Using any other input but integer inside rocket_atf_warmup_links filter, filter will not work (which is expected) but nor will there be any URLs fetched.

To Reproduce
Steps to reproduce the behavior:

  1. Add snippet:
    add_filter( 'rocket_atf_warmup_links_number', function () { return ; });
  2. For return value use any non-integer inputs (i.e null, 0, -10, 3.14, [ ], "")
  3. Save and activate filter
  4. Clear Critical Images
  5. Check wp-rocket-debug.log.html file
  6. Notice there are no "Add to queue request arguments" logs inside it, so no links were fetched.

Expected behavior
In the case where rocket_atf_warmup_links_number filter is given the wrong kind of input, then the fetch mechanism should default to 10 URLs + home.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming

@hanna-meda hanna-meda added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement priority: low Issues that can wait severity: minor Defect that does not affect functionality labels Apr 19, 2024
@hanna-meda hanna-meda added this to the 3.16 milestone Apr 19, 2024
@remyperona remyperona self-assigned this Apr 22, 2024
@remyperona remyperona added the effort: [XS] < 1 day of estimated development time label Apr 22, 2024
@MathieuLamiot MathieuLamiot linked a pull request Apr 24, 2024 that will close this issue
14 tasks
@benorfaz benorfaz added the lcp label May 2, 2024
@piotrbak piotrbak closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: [XS] < 1 day of estimated development time priority: low Issues that can wait severity: minor Defect that does not affect functionality type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants