Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude CallRail's script from JS Minification #4405

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

vmanthos
Copy link
Contributor

@vmanthos vmanthos commented Oct 6, 2021

Description

Storing the file locally during JavaScript minification breaks the script.
Ticket: https://secure.helpscout.net/conversation/1644626876/297711/

Type of change

  • Enhancement (non-breaking change which improves an existing functionality)

Is the solution different from the one proposed during the grooming?

Not applicable.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • On my local test site.

Checklist:

Please delete the options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Storing the file locally during JavaScript minification breaks the script.
Ticket: https://secure.helpscout.net/conversation/1644626876/297711/
@remyperona remyperona added this to the 3.10.1 milestone Oct 6, 2021
@remyperona remyperona merged commit 61b63a5 into develop Oct 6, 2021
@remyperona remyperona deleted the enhancement/exclude-callrail-js-minification branch October 6, 2021 18:21
@remyperona remyperona mentioned this pull request Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants