Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6281: Task/lcp refactor rucss api cron queue #6307

Conversation

jeawhanlee
Copy link
Contributor

Description

Refactor RUCSS, cron, queue and API module.

Fixes #6281

Type of change

sub-task

Is the solution different from the one proposed during the grooming?

No

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

Copy link
Contributor

@CrochetFeve0251 CrochetFeve0251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per discussion with @jeawhanlee the routing from old hooks to new hooks will be done later on.
Same for testing.

inc/Engine/Common/Database/Table.php Outdated Show resolved Hide resolved
inc/Engine/Media/AboveTheFold/Jobs/Factory.php Outdated Show resolved Hide resolved
inc/Engine/Media/AboveTheFold/Jobs/Factory.php Outdated Show resolved Hide resolved
inc/Engine/Media/AboveTheFold/Jobs/Factory.php Outdated Show resolved Hide resolved
inc/Engine/Media/AboveTheFold/Jobs/Factory.php Outdated Show resolved Hide resolved
inc/Engine/Media/AboveTheFold/Jobs/Factory.php Outdated Show resolved Hide resolved
inc/Engine/Media/AboveTheFold/Jobs/Factory.php Outdated Show resolved Hide resolved
jeawhanlee and others added 12 commits December 14, 2023 20:22
Co-authored-by: Rémy Perona <remy@wp-media.me>
Co-authored-by: Rémy Perona <remy@wp-media.me>
Co-authored-by: Rémy Perona <remy@wp-media.me>
Co-authored-by: Rémy Perona <remy@wp-media.me>
Co-authored-by: Rémy Perona <remy@wp-media.me>
Co-authored-by: Rémy Perona <remy@wp-media.me>
Co-authored-by: Rémy Perona <remy@wp-media.me>
Co-authored-by: Rémy Perona <remy@wp-media.me>
Co-authored-by: Rémy Perona <remy@wp-media.me>
Co-authored-by: Rémy Perona <remy@wp-media.me>
@jeawhanlee jeawhanlee merged commit b0d1b4e into feature/lcp-above-the-fold-optimization Dec 15, 2023
1 of 7 checks passed
@jeawhanlee jeawhanlee deleted the task/lcp-refactor-rucss-api-cron-queue branch December 15, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: sub-task Indicates the issue is a sub-task linked to an epics card
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LCP & Above the Fold: Refactor the RUCSS API, Queue and CRON
4 participants