Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6621 Increase phpstan level to level 1 #6754

Merged
merged 13 commits into from
Jul 8, 2024

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Jul 2, 2024

Description

Fixes #6621

Documentation

User documentation

It won't impact users.

Technical documentation

This PR simply changes some things on how the code is structured to comply with php-stan.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

New dependencies

Risks

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Documentation

  • I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
  • The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
  • I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.
  • I listed the introduced external dependencies explicitely on the PR.
  • I validated the repo-specific guidelines from CONTRIBUTING.md.

Observability

  • I handled errors when needed.
  •  I wrote user-facing messages that are understandable and provide actionable feedbacks.
  • I prepared ways to observe the implemented system (logs, data, etc.).

Risks

  •  I explicitely mentioned performance risks in the PR.
  • I explicitely mentioned security risks in the PR.

@Miraeld Miraeld added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement dev initiative labels Jul 2, 2024
@Miraeld Miraeld self-assigned this Jul 2, 2024
@Miraeld Miraeld changed the title Enhancement/6621 increase phpstan level Closes #6621: increase phpstan level Jul 2, 2024
Copy link

codacy-production bot commented Jul 2, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 63677421 40.48% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6367742) Report Missing Report Missing Report Missing
Head commit (9f3886d) 37370 14545 38.92%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6754) 42 17 40.48%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@Miraeld Miraeld requested a review from a team July 2, 2024 05:28
inc/Engine/Optimization/RUCSS/Controller/UsedCSS.php Outdated Show resolved Hide resolved
inc/ThirdParty/Hostings/LiteSpeed.php Outdated Show resolved Hide resolved
inc/ThirdParty/Plugins/SEO/SEOPress.php Outdated Show resolved Hide resolved
@remyperona remyperona changed the title Closes #6621: increase phpstan level Closes #6621 Increase phpstan level to level 1 Jul 3, 2024
@Miraeld Miraeld requested a review from remyperona July 4, 2024 01:30
phpstan-bootstrap.php Outdated Show resolved Hide resolved
@remyperona remyperona self-requested a review July 8, 2024 13:45
@MathieuLamiot
Copy link
Contributor

@Miraeld can this be merged and moved to Done?

@remyperona remyperona added this pull request to the merge queue Jul 8, 2024
Merged via the queue into develop with commit d70151f Jul 8, 2024
12 of 13 checks passed
@remyperona remyperona deleted the enhancement/6621-increase-phpstan-level branch July 8, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev initiative type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase PHPStan to rule level to 1
3 participants