Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6807 Changed link for rucss display notice #6815

Merged
merged 8 commits into from
Aug 2, 2024

Conversation

Khadreal
Copy link
Contributor

Description

Fixes #6807

Documentation

Update the support link for when RUCSS db is not created.

User documentation

Explain how this code impacts users.

Technical documentation

Explain how this code works. Diagram & drawings are welcomed.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

New dependencies

List any new dependencies that are required for this change.

Risks

List possible performance & security issues or risks, and explain how they have been mitigated.

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Documentation

  • I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
  • The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
  • I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.
  • I listed the introduced external dependencies explicitely on the PR.
  • I validated the repo-specific guidelines from CONTRIBUTING.md.

Observability

  • I handled errors when needed.
  •  I wrote user-facing messages that are understandable and provide actionable feedbacks.
  • I prepared ways to observe the implemented system (logs, data, etc.).

Risks

  •  I explicitely mentioned performance risks in the PR.
  • I explicitely mentioned security risks in the PR.

@Khadreal Khadreal self-assigned this Jul 25, 2024
@Khadreal Khadreal added the type: enhancement Improvements that slightly enhance existing functionality and are fast to implement label Jul 25, 2024
Copy link

codacy-production bot commented Jul 25, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 612980f1 76.92% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (612980f) Report Missing Report Missing Report Missing
Head commit (23d8c47) 37351 14554 38.97%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6815) 13 10 76.92%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@Khadreal Khadreal marked this pull request as ready for review July 25, 2024 10:57
@Khadreal Khadreal requested a review from a team July 25, 2024 10:57
@remyperona remyperona changed the title :closes: Changed link for rucss display notice --#6807 Closes #6807 Changed link for rucss display notice Jul 25, 2024
@Khadreal Khadreal requested a review from remyperona July 26, 2024 09:47
@MathieuLamiot
Copy link
Contributor

@Khadreal If this is NoQA, can this be moved to QA Done then? We would only need you to simply validate the banner is OK manually.

@Khadreal
Copy link
Contributor Author

Screenshot

Screenshot 2024-07-31 at 09 44 00
See bottom left for the link when you hover on the our support text

@piotrbak
Copy link
Contributor

@Khadreal Good catch, we could change it to:
Please check our documentation and the documentation should be underlined link.

@Khadreal
Copy link
Contributor Author

Updated screenshot

Screenshot 2024-07-31 at 14 46 53

cc @piotrbak

@Khadreal
Copy link
Contributor Author

Khadreal commented Aug 1, 2024

Screenshot 2024-08-01 at 12 35 37
@piotrbak please can we get the french translation of the text so I can update the PO file

@remyperona
Copy link
Contributor

French translation is done via Transifex later on, no need to do it in PR.

@Mai-Saad Mai-Saad added this pull request to the merge queue Aug 2, 2024
Merged via the queue into develop with commit 447336d Aug 2, 2024
13 checks passed
@Mai-Saad Mai-Saad deleted the enhancement/update-rucss-notice#6807 branch August 2, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update "can't create rucss_used_css table" admin notice
5 participants